evil-surround: change / delete delimiters fails

practicalli-johnny commented 10 months ago

Description :octocat:

Evil change / delete surround no longer working, reporting the following error in the buffer, SPC b m

evil-motion-range: No surrounding delimiters found

Assumption: a change in https://github.com/emacs-evil/evil-surround/ occurred on or after 27th June 2023, as the package evil-surround-20230627.2052 functions correctly. This package contains the evil-surround.el with a timestamp of 17 August 2023.

Upstream: an issue has been raised on the evil-surround repo https://github.com/emacs-evil/evil-surround/issues/204 (where it is assumed the issue resides - although happy to be corrected if this assumption is not right) - UPDATE: new package maintainer is aware of the issue and investigating.

Reproduction guide :beetle:

Start Emacs
Open elisp or clojure file (or any lisp language)
Insert ()
In Normal mode, move cursor onto either paren and type d s followed by (
- or use c s followed by (

Observed behaviour: :eyes: :broken_heart:

The () parens are not changed and the no surrounding delimiters found message reported in the Emacs buffer.

Expected behaviour: :heart: :smile:

Using d s folowed by ( should remove both parens, ()

Using c s followed by ( and then ] should replace the parens, () with []

System Info :computer:

OS: gnu/linux
Emacs: 30.0.50
Spacemacs: 0.999.0
Spacemacs branch: develop (rev. b86a07443)
Graphic display: t
Running in daemon: nil
Distribution: spacemacs
Editing style: vim
Completion: helm

Layers:

((auto-completion :variables auto-completion-enable-help-tooltip t
              auto-completion-enable-snippets-in-popup t
              auto-completion-enable-sort-by-usage t
              auto-completion-idle-delay 0.0
              auto-completion-minimum-prefix-length 1
              auto-completion-complete-with-key-sequence "fd")
(clojure :variables clojure-enable-kaocha-runner t
      cider-repl-display-help-banner nil cider-print-fn 'puget
      clojure-indent-style 'align-arguments
      clojure-align-forms-automatically t
      clojure-toplevel-inside-comment-form t cider-result-overlay-position
      'at-point cider-overlays-use-font-lock t cider-repl-buffer-size-limit
      100 nrepl-use-ssh-fallback-for-remote-hosts t)
colors command-log csv (docker :variables docker-dockerfile-backend 'lsp)
emacs-lisp emoji
(git :variables git-magit-status-fullscreen t magit-diff-refine-hunk t
  git-enable-magit-todos-plugin t)
graphviz helm html javascript json
(lsp :variables lsp-headerline-breadcrumb-enable t
  lsp-headerline-breadcrumb-segments '(symbols) lsp-ui-peek-enable nil
  lsp-semantic-tokens-enable t lsp-treemacs-error-list-current-project-only
  t lsp-idle-delay 1.5 lsp-eldoc-enable-hover nil lsp-ui-doc-enable nil
  lsp-ui-sideline-enable nil treemacs-space-between-root-nodes nil
  lsp-log-io t)
markdown multiple-cursors
(org :variables org-enable-github-support t org-enable-bootstrap-support t
  org-want-todo-bindings t org-enable-org-journal-support t org-journal-dir
  "~/projects/journal/" org-journal-file-format "%Y-%m-%d"
  org-journal-date-prefix "#+TITLE: " org-journal-date-format "%A, %B %d %Y"
  org-journal-time-prefix "* " org-journal-time-format ""
  org-journal-carryover-items
  "TODO=\"TODO\"|TODO=\"DOING\"|TODO=\"BLOCKED\"|TODO=\"REVIEW\"")
(ranger :variables ranger-show-preview t ranger-show-hidden t
     ranger-cleanup-eagerly t ranger-cleanup-on-disable t
     ranger-ignored-extensions '("mkv" "flv" "iso" "mp4"))
(shell :variables shell-default-shell 'vterm shell-default-term-shell
    "/usr/bin/zsh" shell-default-height 30 shell-default-position 'bottom)
(spacemacs-layouts :variables spacemacs-layouts-restrict-spc-tab t
                persp-autokill-buffer-on-remove 'kill-weak)
(spacemacs-modeline :variables doom-modeline-height 12 doom-modeline-bar-width
                 0 doom-modeline-buffer-state-icon t
                 doom-modeline-major-mode-color-icon t
                 doom-modeline-buffer-file-name-style 'relative-to-project
                 doom-modeline-display-default-persp-name t
                 doom-modeline-minor-modes nil doom-modeline-modal nil
                 doom-modeline-buffer-encoding nil)
spell-checking
(syntax-checking :variables syntax-checking-use-original-bitmaps t)
(treemacs :variables treemacs-indentation 1 treemacs-use-filewatch-mode t
       treemacs-use-follow-mode t)
(unicode-fonts :variables unicode-fonts-enable-ligatures t
            unicode-fonts-ligature-modes '(prog-mode))
(version-control :variables version-control-diff-tool 'diff-hl
              version-control-global-margin t)
(yaml :variables yaml-enable-lsp t))

System configuration features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Backtrace :paw_prints:

<<BACKTRACE IF RELEVANT>>

practicalli-johnny commented 10 months ago

Pinning the evil-surround package to an ealier version is a temporary resolution to the issue.

Edit the Spacemacs user configuration and add a recipe for evil-surround to pin the older version (pinned even during package updates).

Newer versions of evil-surround should be deleted from elpa/<emacs-version>/develop and then Emacs restarted, which should automatically download the package from the recipe

   dotspacemacs-additional-packages '((evil-surround
                                       :location
                                       (recipe :fetcher github
                                               :repo "emacs-evil/evil-surround"
                                               :commit "f273821f575ace519066fb106ee45a5b8577475f")))

practicalli-johnny commented 10 months ago

A fix for the issue has been pushed upstream and Melpa has just started a new build cycle so the updated package should be available within 2 hours.

To test before Melpa finishes the build, use the following recipe

(evil-surround
  :location
  (recipe :fetcher github
          :repo "emacs-evil/evil-surround"
          :commit "0d860be74165ceb8314742e4191cdad693f40a6d"))

practicalli-johnny commented 10 months ago

Melpa package updated with fix.

syl20bnr / spacemacs