Helm's action list fails to open with "Cannot split side window or parent of side window" when the current frame is too narrow

Description :octocat:

After https://github.com/emacs-helm/helm/commit/a4380caef3a9e4b1e8d11458852ab67ba9b4cf58 changed helm-show-action-window-other-window's default value to 'left, trying to open the action list for an item fails with Cannot split side window or parent of side window when the frame is too narrow (< 157 chars wide).

When the frame is wide enough ( >= 157 ), then the action window replaces the current result window, regardless of the configured value.

The issue is not present in vanilla emacs using helm on the same version -- the action list is correctly displayed on the left of the current candidates.

The issue happens on emacs-28 and emacs-29 (both tested with a fresh spacemacs config).

Resetting helm-display-function back to the default fixes the issue (though then the helm buffer may be displayed in odd places). The issue seem to be caused by the values provided in spacemacs-helm-display-buffer-regexp. When those conditions are provided, split-window will then fall in

       (and (not (eq window-combination-resize 'side))
         (window-parameter window 'window-side))

condition because (window-parameter window 'window-side) is now 'bottom. split-window will then raise the error.

I'm not sure if there is some tweak we could do in spacemacs//display-helm-window or spacemacs-helm-display-buffer-regexp that would make helm respect the desired position and work with splitted windows for the action list or if we should set helm-show-action-window-other-window to nil by default.

Reproduction guide :beetle:

Start Emacs. Leave it with the default width of 80
Make sure you are using the latest version of helm
Open helm (M-x, find files, ...)
Press C-z to get the action list

Observed behaviour: :eyes: :broken_heart:

A Cannot split side window or parent of side window error is displayed; no action list is shown

Expected behaviour: :heart: :smile:

The action list to be shown

System Info :computer:

OS: gnu/linux
Emacs: 29.1.90
Spacemacs: 0.999.0
Spacemacs branch: develop (rev. dd7b7a2a5)
Graphic display: t
Running in daemon: t
Distribution: spacemacs
Editing style: vim
Completion: helm

Layers:

(csv html
 (unicode-fonts :variables unicode-fonts-enable-ligatures t)
 (ibuffer :variables ibuffer-group-buffers-by 'projects)
 nav-flash theming helm
 (auto-completion :variables auto-completion-front-end 'company auto-completion-enable-snippets-in-popup t auto-completion-enable-help-tooltip nil)
 multiple-cursors
 (git :variables git-enable-magit-gitflow-plugin t magit-bury-buffer-function 'magit-mode-quit-window)
 (version-control :variables version-control-diff-tool 'git-gutter version-control-global-margin nil version-control-diff-side 'left)
 (spell-checking :variables spell-checking-enable-by-default nil spell-checking-enable-auto-dictionary t)
 dtrt-indent
 (lsp :variables lsp-keymap-prefix "C-c C-l" lsp-keep-workspace-alive nil lsp-idle-delay 1 lsp-ui-doc-delay 1 lsp-ui-doc-position 'at-point lsp-use-upstream-bindings nil lsp-pyright-multi-root nil lsp-enable-snippet nil)
 emacs-lisp shell-scripts
 (ipython-notebook)
 (python :variables lsp-pyright-venv-path "/home/kassick/.pyenv/versions" python-auto-set-local-pyenv-version nil python-auto-set-local-pyvenv-virtualenv nil python-test-runner 'pytest python-backend 'lsp python-lsp-server 'pyright python-spacemacs-indent-guess nil python-formatter 'black python-indent-def-block-scale 1)
 rust
 (go :variables go-backend 'lsp go-tab-width 4 company-go-insert-arguments nil lsp-go-use-placeholders nil)
 kzk-go
 (c-c++ :variables c-c++-backend 'lsp-clangd)
 cmake prettier
 (json :variables json-backend 'lsp json-fmt-on-save nil json-fmt-tool 'prettier)
 javascript
 (typescript)
 tide
 (groovy :variables groovy-lsp-jar-path "/home/kassick/Sources/user/groovy-language-server/build/libs/groovy-language-server-all.jar")
 terraform yaml
 (markdown :variables markdown-live-preview-engine 'vmd)
 (org :variables org-enable-modern-support t org-enable-valign t)
 (latex :variables latex-enable-folding t latex-enable-auto-fill nil)
 (bibtex)
 (shell :variables shell-default-height 30 shell-default-position 'bottom)
 kzk-general kzk-evil kzk-window-management kzk-projectile kzk-code-tweaks kzk-mc kzk-embrace kzk-magit kzk-org kzk-lsp kzk-makefile kzk-python kzk-ahs kzk-visual-editing kzk-helm kzk-company kzk-persp spacemacs-editing spacemacs-visual spacemacs-editing-visual)

System configuration features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB

Backtrace :paw_prints:

Debugger entered--Lisp error: (wrong-number-of-arguments #f(compiled-function (ad--addoit-function window &optional norecord) #<bytecode -0x1000896e52a7d7fe>) 1)
  ad-Advice-select-window(#<subr select-window>)
  apply(ad-Advice-select-window #<subr select-window> nil)
  select-window()
  (window-parameter (select-window) 'split-window)
  eval-expression((window-parameter (select-window) 'split-window) nil nil 127)
  funcall-interactively(eval-expression (window-parameter (select-window) 'split-window) nil nil 127)
  command-execute(eval-expression)

syl20bnr / spacemacs