syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.58k stars 4.9k forks source link

Do not show any minibuffer when using spacemacs/window-split-triple-columns #16208

Closed lesteve closed 6 months ago

lesteve commented 7 months ago

I noticed that SPC w 3 i.e. spacemacs/window-split-triple-columns always shows a inactive minibuffer e.g. a buffer like *Minibuf-1*, *Minibuf-2*.

Here is a screenshot that shows an example where I do SPC w 3:

image

When you switch to the window with a minibuffer, the key bindings are not the spacemacs ones and you need to do C-x b to switch to a different buffer which makes the user experience not so great. This affects SPC w 4 as well.

To reproduce it, start emacs, and then SPC w 3, one of the window should be a *Minibuf-<some-number>*.

This used to work at one point and I traced it back to https://github.com/syl20bnr/spacemacs/pull/15520 that removed the #'buffer-file-name filter when splitting windows with SPC w 3. The PR relies on #'persp-contain-buffer-p instead but this is not filtering out minibuffers if you are in the Default layout. For completeness, personally I don't use layouts.

System Info :computer: