syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.58k stars 4.9k forks source link

Can't use ripgrep/rg search symbol in project #16243

Closed ccruquan closed 6 months ago

ccruquan commented 6 months ago

Description :octocat:

Can't use ripgrep/rg search symbol in project

Reproduction guide :beetle:

Observed behaviour: :eyes: :broken_heart: A message says rg: invalid CLI arguments: unexpected argument for option '--ignore': ".#*"

Expected behaviour: :heart: :smile: Use ripgrep/rg search symbol in project

System Info :computer:

Backtrace :paw_prints:

<<BACKTRACE IF RELEVANT>>
ccruquan commented 6 months ago

I check the key binding 'SPC s r p' and find the function spacemacs/helm-project-do-rg. https://github.com/syl20bnr/spacemacs/blob/3d84b01172d68f09791210d7de385f596ccf26b7/layers/%2Bcompletion/helm/funcs.el#L173

Then I read the code of helm-ag.

helm-ag use '--ignore' option for ignore files: https://github.com/emacsorphanage/helm-ag/blob/501af5cc7d9e9ae4473d84ba1ffb047ad8ef7fae/helm-ag.el#L189

Then I find the option '--ignore' is not used for ignore files in ripgrep doc. https://github.com/BurntSushi/ripgrep/blob/648a65f1976cc3b7eb66425024649d71d5befe1e/doc/rg.1.txt.tpl#L90C38-L90C38

ripgrep use '--iglob'/'--glob' option for ignore files.

alexey0308 commented 6 months ago

it looks like a duplicate https://github.com/syl20bnr/spacemacs/issues/16200

ccruquan commented 6 months ago

thanks