search

syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.66k stars 4.89k forks source link

Migrate most uses of defadvice to advice-add (or define-advice) #16245

Closed bcc32 closed 8 months ago

bcc32 commented 8 months ago

defadvice is more complex and has many quirks, and has long been deprecated in favor of advice-add and related mechanisms.

I did not change the occurrences in the spacemacs-purpose layer, which are a decent bit more complex and also appear to be derived from some upstream. Similarly, I did not modify frame-cmds.el, which is a copy of an upstream file.

macovsky commented 8 months ago

@bcc32 it broke expand-region for me with:

symbol's value as variable is void: return-value

do i have to fix something in my config?

bcc32 commented 8 months ago

Sorry @macovsky! This should be fixed by #16256

macovsky commented 8 months ago

Sorry @macovsky! This should be fixed by #16256

thanks so much!