D layer crashes on flycheck-dmd-dub-set-include-path

Description :octocat:

The D lang layer doesn't work properly because of the function in the title not existing.

Reproduction guide :beetle:

Start Emacs
Install dmd and the D layer

Open any .d file (here's a sample file):

import std.stdio;
void main()
{
writeln("Hello, Spacemacs!");
}

Observed behaviour: :eyes: :broken_heart: I see "File mode specification error: (void-function flycheck-dmd-dub-set-include-path)" and doesn't do anything from there.

Expected behaviour: :heart: :smile: Said message doesn't show and the LSP is started.

System Info :computer:

OS: gnu/linux
Emacs: 29.1
Spacemacs: 0.999.0
Spacemacs branch: develop (rev. 74969c8)
Graphic display: t
Running in daemon: t
Distribution: spacemacs
Editing style: vim
Completion: ivy

Layers:

(systemd auto-completion better-defaults emacs-lisp git parinfer ivy lsp common-lisp markdown multiple-cursors d
     (shell :variables shell-default-height 30 shell-default-position 'bottom shell-default-shell 'vterm)
     syntax-checking version-control pdf treemacs helpful ibuffer spacemacs-modeline spacemacs-navigation themes-megapack shell tree-sitter
     (latex :variables latex-view-with-pdf-tools t latex-enable-auto-fill t latex-enable-magic t magic-latex-enable-suscript nil latex-enable-folding t latex-view-pdf-in-split-window t)
     xclipboard forth
     (org :variables org-enable-bootstrap-support t org-enable-sticky-header t org-enable-valign t org-enable-modern-support t))

System configuration features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS GTK3 ZLIB

Backtrace :paw_prints:

This is from the messages buffer:

Opening file/dir: ~/Code/kilocli/source/app.d
[yas] Prepared just-in-time loading of snippets successfully.
flycheck-dmd-dub [Sun Jan 28 05:34:19 2024]: Setting variables from dub describe
flycheck-dmd-dub [Sun Jan 28 05:34:19 2024]: Cache invalidated, running dub describe.
flycheck-dmd-dub [Sun Jan 28 05:34:19 2024]: Calling dub describe with ’dub describe’
flycheck-dmd-dub [Sun Jan 28 05:34:19 2024]: Caching result of dub describe
flycheck-dmd-dub [Sun Jan 28 05:34:19 2024]: Creating directory /tmp/flddRx1ez9/home/stefan/Code/kilocli/
flycheck-dmd-dub [Sun Jan 28 05:34:19 2024]: Setting variables from JSON string
File mode specification error: (void-function flycheck-dmd-dub-set-include-path)

This happens because the layer supposedly hasn't been updated and that function doesn't exist in flycheck-dmd-dub. It stems from here: https://github.com/syl20bnr/spacemacs/blob/develop/layers/%2Blang/d/packages.el#L62. Removing the offending line makes everything work again, I'll make a PR with that fix.

syl20bnr / spacemacs