Entering transient states replaces current buffer contents with transient buffer contents

fleimgruber commented 4 months ago

Description :octocat:

Transient state replaces current buffer contents with transient buffer contents

Reproduction guide :beetle:

Tested with two different transient states: paste and spell-checking

Start Emacs
(setq dotspacemacs-enable-paste-transient-state t) and paste in the current buffer

OR:

Start Emacs
spacemacs/spell-checking-transient-state/body

Observed behaviour: :eyes: :broken_heart: Current buffer gets replaced with transient state buffer, e.g. in case of spell checking

Spell Checking Transient State
Spell Commands            Add To Dictionary               Other
------------------------  ------------------------------  --------------------------------
[b] check whole buffer    [B] add word to dict (buffer)   [t] toggle spell check
[r] check region          [G] add word to dict (global)   [q] exit
[d] change dictionary     [S] add word to dict (session)  [Q] exit and disable spell check
[n] next spell error
[c] correct before point
[s] correct at point
[KEY] exits state  [KEY] will not exit

Expected behaviour: :heart: :smile: Transient state buffer gets created in a different window, current buffer contents are not replaced.

System Info :computer:

OS: windows-nt
Emacs: 29.2.50
Spacemacs: 0.999.0
Spacemacs branch: develop (rev. 2dadee571)
Graphic display: t
Running in daemon: nil
Distribution: spacemacs
Editing style: vim
Completion: (compleseus)

Layers:

(ruby
(org :variables org-enable-org-contacts-support t org-contacts-files
  `(,(expand-file-name "~/lg/contacts.org"))
  org-enable-reveal-js-support t org-enable-org-journal-support t org-journal-file-type 'yearly org-journal-dir
  (expand-file-name "~/lg")
  org-journal-date-format "%A, %d %B %Y" org-reverse-note-order t org-enable-roam-support t org-enable-roam-ui t org-enable-appear-support t org-enable-transclusion-support t org-enable-modern-support t org-modern-hide-stars nil org-auto-align-tags nil org-tags-column 0 org-catch-invisible-edits 'show-and-error org-special-ctrl-a/e t org-insert-heading-respect-content nil org-hide-emphasis-markers t org-pretty-entities t org-ellipsis "…" org-agenda-tags-column 0 org-agenda-block-separator 9472 org-agenda-time-grid
  '((daily today require-timed)
    (800 1000 1200 1400 1600 1800 2000)
    " ┄┄┄┄┄ " "┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄")
  org-agenda-current-time-string "⭠ now ─────────────────────────────────────────────────")
pbz
(tree-sitter :variables tree-sitter-syntax-highlight-enable t tree-sitter-fold-enable t tree-sitter-fold-indicators-enable nil)
treemacs polymode
(latex :variables latex-backend 'lsp)
csv pdf finance multiple-cursors semantic-web jabber dash
(javascript :variables javascript-import-tool 'import-js javascript-repl 'nodejs)
tern bibtex
(auto-completion :variables auto-completion-enable-sort-by-usage t auto-completion-enable-snippets-in-popup t auto-completion-private-snippets-directory "~/.spacemacs.d/snippets/")
csharp sphinx restructuredtext
(lsp :variables lsp-prefer-flymake nil)
dap emacs-lisp
(git :variables git-enable-magit-svn-plugin t)
octave sql html
(markdown :variables markdown-command "pandoc")
pandoc
(windows-scripts :toggle
              (eq system-type 'windows-nt))
(shell-scripts :toggle
            (or
             (eq system-type 'darwin)
             (eq system-type 'gnu)))
(shell :variables shell-enable-smart-eshell t)
(elfeed :variables elfeed-goodies/entry-pane-position 'bottom rmh-elfeed-org-files
     (list "~/lg/elfeed.org"))
spell-checking syntax-checking
(version-control :variables version-control-diff-tool 'diff-hl version-control-diff-side 'left)
(osx)
graphviz nixos systemd gnus
(c-c++ :variables c-c++-enable-clang-support t c-c++-backend 'lsp-ccls)
protobuf
(go :variables go-tab-width 4 go-backend 'lsp go-format-before-save t)
(lua :variables lua-backend 'lsp)
rust
(clojure :variables clojure-enable-clj-refactor t cider-repl-display-help-banner nil cider-pprint-fn 'fipp clojure-indent-style 'align-arguments clojure-align-forms-automatically t clojure-toplevel-inside-comment-form t cider-result-overlay-position 'at-point cider-overlays-use-font-lock t cider-repl-buffer-size-limit 100)
erlang
(python :variables python-test-runner 'pytest python-backend 'lsp python-lsp-server 'pylsp python-fill-column 120)
(julia :variables julia-backend 'lsp julia-mode-enable-ess nil)
haskell java elm
(zig :variables zls-backend 'lsp zig-format-show-buffer nil zig-format-on-save t zig-return-to-buffer-after-format t)
(elixir :variables elixir-backend 'lsp)
autohotkey restclient compleseus)

System configuration features: ACL DBUS GIF GMP GNUTLS HARFBUZZ IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP XPM ZLIB

Backtrace :paw_prints:

fleimgruber commented 4 months ago

I narrowed this down to my local layer config, will bisect some more.

fleimgruber commented 4 months ago

It turns out the offending parts were these, based on https://www.masteringemacs.org/article/demystifying-emacs-window-manager#example-2-reusing-windows. Might well be an oversight on my part. I did not dissect it further, just wanted to have it here for reference if others stumble in a similar way.

(setq switch-to-buffer-obey-display-actions t)

(add-to-list 'display-buffer-alist
             `(,(rx (| "*xref*"
                       "*grep*"
                       "*Occur*"
                       (and "*deadgrep" (* not-newline) "*")))
               display-buffer-reuse-window
               (inhibit-same-window . nil)))

(add-to-list 'display-buffer-alist
             '(,(rx (and "*deadgrep" (* not-newline) "*"))
               display-buffer-reuse-mode-window
               ;; change to `t' to not reuse same window
               (inhibit-same-window . nil)
               (mode deadgrep-mode)))

(defun make-display-buffer-matcher-function (major-modes)
  (lambda (buffer-name action)
    (with-current-buffer buffer-name (apply #'derived-mode-p major-modes))))

(add-to-list 'display-buffer-alist
             `(,(make-display-buffer-matcher-function '(deadgrep-mode))
               (display-buffer-reuse-mode-window
                display-buffer-in-direction)
               (mode deadgrep-mode)))

syl20bnr / spacemacs