Custom option `desktop-save-mode t` now loads `desktop` automatically upon launch (new behavior)

Description :octocat:

For the past 5 years, I've had the custom option '(desktop-save-mode t) set under (custom-set-variables) at the end section of my dotfile. What it did was offering to save my current desktop settings: opened files, buffer order, etc. to a desktop config file under ~/.emacs.d/.cache, so upon launching Emacs again (not in daemon mode), I would have the choise of starting fresh and opening a single file for editing, or pressing SPC SPC and selecting desktop-read to bring up my previously saved session configuration.

However, after the last develop update (that fixed the helm-descbinds vs which-key problem), this behavior has been altered: Now, the custom option desktop-save-mode t loads desktop automatically upon launching (new behavior, instead of requiring me to SPC SPC desktop-read). This is undesired, as one no longer has the choice of either freshly starting up Emacs to edit a couple of files or continuing a workflow.

Reproduction guide :beetle:

Start Emacs
Edit dotfile: scroll to the end, and under (custom-settings) add '(desktop-save-mode t)
Restart Emacs
Open a few files
Press SPC q q or C-x C-c to quit Emacs
You should be prompted to save desktop? y/n; press y to save your current desktop layout
Start Emacs again

Observed behaviour: :eyes: :broken_heart: After starting Emacs again, after having saved the desktop, this desktop session will be automatically restored, without having the choice of restoring it at will. Disabling '(desktop-save-mode t) is a workaround, but defeats the purpose of automatically saving the desktop.

Expected behaviour: :heart: :smile: Emacs starts as a fresh launch greeting you with the Spacemacs buffer, without any files open, giving you the choice of opening a couple of files for a quick edit and save, asking you if you want to save your desktop or not. You also have the chance of SPC SPC desktop-read to restore your previous session, as usual.

System Info :computer:

OS: darwin
Emacs: 29.2
Spacemacs: 0.999.0
Spacemacs branch: develop (rev. 4a227fc94)
Graphic display: t
Running in daemon: nil
Distribution: spacemacs
Editing style: hybrid
Completion: helm

Layers:

((c-c++ :variables c-c++-adopt-subprojects t c-c++-backend 'lsp-clangd c-c++-dap-adapters
    '(dap-lldb dap-gdb-lldb dap-cpptools)
    c-c++-enable-clang-format-on-save t)
csv
(dart :variables dart-backend 'lsp lsp-dart-sdk-dir "/Users/dmayr/flutter/bin/cache/dart-sdk" lsp-enable-on-type-formatting t)
emacs-lisp
(go :variables go-backend 'lsp go-dap-mode 'dap-go go-format-before-save t go-use-golangci-lint t go-use-test-args "-race -timeout 10s" godoc-at-point-function 'godoc-gogetdoc gofmt-command "gofumpt")
(html :variables web-fmt-tool 'prettier)
(java :variables java-backend 'lsp)
(javascript :variables javascript-backend 'lsp javascript-fmt-on-save t javascript-fmt-tool 'prettier javascript-import-tool 'import-js javascript-lsp-linter nil js2-mode-show-parse-errors nil js2-mode-show-strict-warnings nil js-indent-level 4 js2-basic-offset 4 js2-include-node-externs t)
(json :variables json-fmt-on-save t json-fmt-tool 'prettier)
(kotlin :variables kotlin-backend 'lsp)
major-modes
(php :variables php-backend 'ac-php-core)
protobuf
(python :variables python-backend 'lsp python-lsp-server 'pyright python-test-runner
     '(pytest nose))
(ruby :variables ruby-enable-enh-ruby-mode t ruby-version-manager 'rbenv)
(rust :variables rust-backend 'lsp rustic-format-on-save t)
(sql :variables sql-capitalize-keywords t sql-lsp-sqls-workspace-config-path 'workspace)
swift
(typescript :variables typescript-backend 'lsp typescript-fmt-on-save t typescript-fmt-tool 'prettier typescript-lsp-linter nil)
(zig :variables zls-backend 'lsp)
react
(svelte :variables svelte-backend 'lsp)
(vue :variables vue-backend 'lsp)
ansible apache graphql markdown nginx
(shell-scripts :variables shell-scripts-backend 'lsp shell-scripts-format-on-save t)
(yaml :variables yaml-enable-lsp t)
(auto-completion :variables auto-completion-enable-help-tooltip t auto-completion-enable-snippets-in-popup t auto-completion-enable-sort-by-usage t)
better-defaults chrome dtrt-indent
(geolocation :variables geolocation-enable-automatic-theme-changer t geolocation-enable-location-service t)
(helm :variables spacemacs-helm-rg-max-column-number 1024)
helpful
(ibuffer :variables ibuffer-group-buffers-by 'projects)
imenu-list
(lsp :variables lsp-lens-enable t lsp-ui-remap-xref-keybindings t lsp-ui-sideline-show-symbol t)
multiple-cursors nav-flash
(org :variables org-enable-appear-support t org-enable-asciidoc-support t org-enable-bootstrap-support t org-enable-github-support t org-enable-hugo-support t org-enable-jira-support t org-enable-org-journal-support t org-enable-valign t org-journal-dir "/Users/dmayr/Documents/org-journal" org-todo-dependencies-strategy 'naive-auto)
(osx :variables osx-command-as 'super osx-control-as 'control osx-function-as 'none osx-option-as 'meta osx-right-command-as 'control osx-right-control-as 'control osx-right-option-as 'none osx-swap-option-and-command nil)
pdf
(shell :variables close-window-with-terminal t multi-term-program "/usr/local/bin/zsh" shell-default-height 30 shell-default-position 'bottom shell-default-shell 'vterm shell-default-term-shell "/usr/local/bin/zsh" spacemacs-vterm-history-file-location "~/.zsh_history")
(spell-checking :variables enable-flyspell-auto-completion t spell-checking-enable-auto-dictionary t spell-checking-enable-by-default nil)
(treemacs :variables treemacs-use-all-the-icons-theme t treemacs-use-collapse-dirs 3 treemacs-use-git-mode 'deferred treemacs-use-scope-type 'Perspectives)
(unicode-fonts :variables unicode-fonts-force-multi-color-on-mac t)
(cmake :variables cmake-backend 'lsp cmake-enable-cmake-ide-support t)
colors dap debug
(docker :variables docker-dockerfile-backend 'lsp)
(git :variables git-enable-magit-delta-plugin t git-enable-magit-gitflow-plugin t git-enable-magit-svn-plugin t git-enable-magit-todos-plugin t)
gtags import-js openai pandoc prettier quickurl
(syntax-checking :variables syntax-checking-auto-hide-tooltips 3)
templates
(version-control :variables version-control-diff-tool 'diff-hl)
(xclipboard :variables xclipboard-enable-cliphist t))

System configuration features: ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS ZLIB

syl20bnr / spacemacs