search

syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.57k stars 4.9k forks source link

Add .dir-locals.el to discourage accidentally modifying packages #16350

Open bcc32 opened 3 months ago

bcc32 commented 3 months ago

Not sure if this would be controversial, but I do find myself frequently editing installed packages when I meant to be editing a git checkout of them. I think it's usually not productive to edit installed packages because edits will be overwritten whenever the package is upgraded, so this should help mitigate this footgun.

bcc32 commented 3 months ago

Hmm, I don't really understand why the CI build is failing. I don't see any errors like this when installing packages by hand.

smile13241324 commented 1 month ago

hmm this seems to kill package installation on base

allentiak commented 1 month ago

@bcc32 It seems there have been some changes to the elisp tests workflow file. (See https://github.com/syl20bnr/spacemacs/commit/ffcfff353c137398d2bf3d29198dabfdef7a2bf6.)

Have you tried rebasing your changes on current develop?

smile13241324 commented 1 month ago

This seems to make autoloaded files read only.

An error occurred while installing evil (error: (error goto-chg-pkg.el:0:0: error: buffer-read-only: ( *autoload-file*)))