syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.57k stars 4.9k forks source link

fix smartparens-mode inserts double ' in minibuffer #16353

Closed dankessler closed 1 month ago

dankessler commented 3 months ago

smartparens-mode is sometimes activated in the minibuffer by spacemacs//conditionally-enable-smartparens-mode, specifically if we are in the minibuffer due to eval-expression (or eldoc-eval-expression). This is convenient for things like parens, but we don't want this behavior on a single quote. It looks like we tried to stop this, but for whatever reason that configuration was for minibuffer-inactive-mode rather than minibuffer-mode. The former is the major mode of the minibuffer when it is not active, whereas the latter is the major mode of the minibuffer when it is active. This has been part of spacemacs for a long time, so I've simply added configuration for minibuffer-mode and left behind the configuration for minibuffer-inactive-mode in case somebody was relying on that