syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.57k stars 4.9k forks source link

Small improvements to core-load-paths.el #16355

Closed bcc32 closed 1 month ago

sunlin7 commented 1 month ago

Hi @bcc32 Why change the .cache folder from ~/.emacs.d/ to the spacemacs installation folder? https://github.com/syl20bnr/spacemacs/pull/16355/files#diff-2ed2a13c6fbd6262b08ee51062ff34063a31838546235aea0a1dceebd81a1a3aL98

bcc32 commented 1 month ago

Most of the time ~/.emacs.d/ is in fact the spacemacs installation directory. But, if a user installs spacemacs to a different directory, Spacemacs's state should live there. It's also consistent with all the other spacemacs-*- directory definitions in that file. Is there a case where you think this is the wrong behavior?

sunlin7 commented 1 month ago

Hi @bcc32 I deployed the Spacemacs in a readonly (shared) path, and the .cache should be a per user settings.

bcc32 commented 1 month ago

Aha, that's a great point. Submitted #16409 to revert that particular change and add an explanatory comment. Thanks for pointing this out, @sunlin7 .

sunlin7 commented 1 month ago

Thank you more !