syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.56k stars 4.9k forks source link

Fix helm-spacemacs-help-faq #16442

Closed GreenRecycleBin closed 3 weeks ago

GreenRecycleBin commented 3 weeks ago

In https://github.com/syl20bnr/spacemacs/pull/13136, helm-spacemacs-help-faq supporting functions were rewritten because helm-org-get-candidates was removed upstream (https://github.com/emacs-helm/helm-org/pull/10).

One of the supporting functions, helm-spacemacs-help//get-faq-headings-list, doesn't work. As a result, helm-spacemacs-help-faq (M-m h f) fails with "if: Wrong type argument: stringp, helm".

It's unclear if this bug has existed since the Spacemacs PR because helm-org-build-sources has changed since the helm-org PR (https://github.com/emacs-helm/helm-org/commits/master/helm-org.el).

GreenRecycleBin commented 3 weeks ago

This will fix https://github.com/syl20bnr/spacemacs/issues/16441 :)