syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.56k stars 4.9k forks source link

[core] Fix warnings '* is an obsolete alias ... use ‘cl-*’ instead.' #16460

Closed Bost closed 5 days ago

bcc32 commented 1 week ago

I think these files are automatically imported from the Emacs Wiki into the Spacemacs repo and updated by a bot, so these fixes would be overwritten in the next import. See this commit as an example.

They should probably be fixed by updating the Emacs Wiki instead, although I don't know what the process for doing that is.

smile13241324 commented 6 days ago

I am not sure if these files are updated regularly, I'll close the pr if they are.

Bost commented 5 days ago

Ah yeah, you're right. The files are imported from: https://www.emacswiki.org/emacs/download/zoom-frm.el https://www.emacswiki.org/emacs/download/frame-cmds.el

doc/CI_PLUMBING.org says:

Built-in updates

Bash script .circleci/built_in/upd_built_in reads .ci/built_in_manifest file line by line and downloads every listed file into its specified location overriding existing ones.

And then:

$ rg --no-line-number frame-cmds.el\|zoom-frm.el .ci/built_in_manifest
https://raw.githubusercontent.com/emacsmirror/frame-cmds/master/frame-cmds.el layers/+spacemacs/spacemacs-visual/local/zoom-frm/frame-cmds.el
https://raw.githubusercontent.com/emacsmirror/zoom-frm/master/zoom-frm.el layers/+spacemacs/spacemacs-visual/local/zoom-frm/zoom-frm.el
smile13241324 commented 5 days ago

Then I am going to close this PR, thanks for making sure.