search

syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.67k stars 4.89k forks source link

Add keybinding conventions for symbol usage highlighting #347

Closed bjarkevad closed 9 years ago

bjarkevad commented 9 years ago

I'm not completely sure that something like this doesn't already exist within Spacemacs, but I haven't been able to find it. Anyways, for the Haskell layer i suggest the following bindings:

"muu" 'haskell-mode-find-uses "mun" 'highlight-uses-mode-next "muN" 'highlight-uses-mode-prev "mur" 'highlight-uses-mode-replace "muc" 'highlight-uses-mode-stop-here

Does it make sense to use these bindings as a general convention for usage highlighting?

syl20bnr commented 9 years ago

In the spacemacs layer highlight shares its prefix with help commands. Can be found here https://github.com/syl20bnr/spacemacs/blob/master/spacemacs/config.el#L15 or in the guide-key pop up. (https://github.com/syl20bnr/spacemacs/blob/master/doc/DOCUMENTATION.md#stacking-highlights)

Do you know if there is intelligence in haskell-mode-find-uses or is it roughly the same as SPC s e for iedit ? (https://github.com/syl20bnr/spacemacs/blob/master/doc/DOCUMENTATION.md#replacing-text-with-iedit)

bjarkevad commented 9 years ago

haskell-mode-find-uses does have a bit of logic behind it, but I don't feel like it adds a whole lot of value. I think I'll just close this issue for now, thanks for clarifying.