syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.67k stars 4.89k forks source link

How to deactivate highlighting of trailing whitespace? #4419

Closed 3rd3 closed 8 years ago

3rd3 commented 8 years ago

I've already tried this, but it had no effect:

(setq-default show-trailing-whitespace nil)
tuhdo commented 8 years ago

You have to set:

(setq-default spacemacs-show-trailing-whitespace nil)
3rd3 commented 8 years ago

Thanks tuhdo! How can I find this out myself in future?

tuhdo commented 8 years ago

I press C-h v and type trailing whitespace or whitespace trailing (or shorter), then I found that variable by using <leader> / and enter the same query. Normally, you should be able to jump directly to the variable by moving the cursor to the file name, press enter. It is because the variable is created with setq but not proeprly defvar.

canonic-epicure commented 7 years ago

(setq-default spacemacs-show-trailing-whitespace nil) does not work for me..

I actually have it as:

(setq-default spacemacs-show-trailing-whitespace nil)

(defun my-tabs-setup ()   
    (setq spacemacs-show-trailing-whitespace nil)
)

(add-hook 'haskel-mode-hook 'my-tabs-setup)

Any help?

3rd3 commented 7 years ago

haskell?

vishesh1232 commented 6 years ago

(setq-default spacemacs-show-trailing-whitespace nil) did not work for me either. I'm setting it under dotspacemacs/user-config.

Are there any known workarounds?

zeka0 commented 6 years ago

You can alt-x to find 'delete-trailing-whitespace' command.

Nielius commented 5 years ago

For me, on Spacemacs: 0.300.0, Emacs 26.1, (setq show-trailing-whitespace nil) worked, but (setq spacemacs-show-trailing-whitespace nil) did not, at least when I tried it in a single buffer that was already open.

paxsali commented 3 years ago

I would like to know how I can customize the way Spacemacs is indicating the trailing whitespace. It used to be bright blue, now are few updates it became red and I'd like to change it. Is there a customize-group for this?

I'm on Spacemacs version "develop fc2aa2601" / 0.300.0, Emacs 27.1.50.

alexey0308 commented 3 years ago

I have different or no colour depending on the current theme, hence it is specified within the themes. You can use M-x customize-face and select trailing-whitespaces to set own colour.

rkachach commented 2 years ago

Not working for me either. I'm using diff-hl mode and when I show the diff (on the vc-diff buffer) it shows the trailing space dots even when I have disabled both variables. Right now I have the following on my user-config section:

  (setq show-trailing-whitespace nil)
  (setq spacemacs-show-trailing-whitespace nil)

my vc-diff buffer looks like: image

And when I check the diff minor-mode configuration (by clicking on it with the mouse) I can see that Show trailing space is checked :(

Any hints on what's wrong with my conf?

lebensterben commented 2 years ago

@rkachach I don't think this is a bug. It's the intended behaviour.

In the vc-diff buffer, press the following :(buffer-local-value 'show-trailing-whitespace (get-buffer "*vc-buffer*")) then press enter.

You will see nil.

rkachach commented 2 years ago

Yeah, I can see that it's nil but I don't then understand what value is vc-diff mode is using to have the trailing spaces enabled.

lebensterben commented 2 years ago

@rkachach Can you post a screenshot with


  asdf

I want to see whether it shows leading spaces differently.

rkachach commented 2 years ago

do you want me to post the source code where this line is inserted?

Note: My problem is that I don't understand why vc-diff is not using the show-trailing-whitespace. Because even if my case this variable is null the 'show white spaces' box appear checked in my Diff minor-mode.

lebensterben commented 2 years ago

@rkachach I want to see a screenshot like the one you posted earlier. But this time I want to see whether vc-diff use a different font face for leading whitespaces.

Because I suspect you're not reporting a bug. It's an intended feature.

rkachach commented 2 years ago

Ah ok, here's another capture (I hope it helps) :)

image

Then I can see that white spaces are enabled (when clicking on Diff minor-mode)

image

When I disable it manually (by using mouse) then I get what would be for me the desired output:

image

lebensterben commented 2 years ago

@rkachach

You first called vc-diff https://github.com/emacs-mirror/emacs/blob/a90dc11e24895c4e6e5bfcfc991d8524f4075223/lisp/vc/vc.el#L1971

which delegates to vc-diff-internal https://github.com/emacs-mirror/emacs/blob/a90dc11e24895c4e6e5bfcfc991d8524f4075223/lisp/vc/vc.el#L1985

and vc-diff-finish https://github.com/emacs-mirror/emacs/blob/a90dc11e24895c4e6e5bfcfc991d8524f4075223/lisp/vc/vc.el#L1864

and diff-setup-whitespace https://github.com/emacs-mirror/emacs/blob/a90dc11e24895c4e6e5bfcfc991d8524f4075223/lisp/vc/vc.el#L1768

The very first line of diff-setup-whitespace is https://github.com/emacs-mirror/emacs/blob/a90dc11e24895c4e6e5bfcfc991d8524f4075223/lisp/vc/diff-mode.el#L1575

which sets the whitespace-style to '(face trailing) and disregard any user configuration.

Also note the documentation of diff-setup-whitespace says

"Set up Whitespace mode variables for the current Diff mode buffer. This sets whitespace-style' andwhitespace-trailing-regexp' so that Whitespace mode shows trailing whitespace problems on the modified lines of the diff."

This is therefore the intended behaviour.

rkachach commented 2 years ago

I see, is there any way to avoid this behavior? I would like to disable the "dot" marks in the output of vc-diff

lebensterben commented 2 years ago

@rkachach Try

(advice-add 'vc-diff-finish
            :after (lambda (_buffer _message)
                     (setq-local whitespace-style nil)
                     (setq-local whitespace-trailing-regexp nil)))
rkachach commented 2 years ago

Thanks. should I added it to the following section?

(defun dotspacemacs/user-config ()
  "Configuration for user code:
lebensterben commented 2 years ago

@rkachach yes

rkachach commented 2 years ago

Still the same issue, this is my config:

(defun dotspacemacs/user-config ()
  "Configuration for user code:
This function is called at the very end of Spacemacs startup, after layer
configuration.
Put your configuration code here, except for variables that should be set
before packages are loaded."
  (with-eval-after-load 'evil
    (define-key evil-emacs-state-map (kbd "C-z") nil))
  (global-company-mode t)

  (require 'diff-hl)
  (require 'flycheck-mypy)
  (diff-hl-flydiff-mode '(:global t))
  (diff-hl-
   margin-mode '(:global t))

  ;;(spacemacs/toggle-indent-guide-globally-on)

  (flycheck-define-checker
      python-mypy ""
      :command ("mypy"
                "--ignore-missing-imports"
                "--python-version" "3.6"
                source-original)
      :error-patterns
      ((error line-start (file-name) ":" line ": error:" (message) line-end))
      :modes python-mode)
  (add-to-list 'flycheck-checkers 'python-mypy t)
  (flycheck-add-next-checker 'python-mypy t)
  (setq flycheck-python-pycompile-executable "/usr/bin/python3")

  (setq show-trailing-whitespace nil)
  (setq spacemacs-show-trailing-whitespace nil)

  (advice-add 'vc-diff-finish
              :after (lambda (_buffer _message)
                       (setq-local whitespace-style nil)
                       (setq-local whitespace-trailing-regexp nil)))
  )
lebensterben commented 2 years ago

@rkachach but it worked for me after restarting Emacs.

rkachach commented 2 years ago

I killed all the emacs processes and restarted emacs but still the same issue. I don't know why the advice-add is not being called when the vc-diff buffer is opened (notice the white space checked when I open the Diff minor mode conf).

image

lebensterben commented 2 years ago

@rkachach In the vc-diff buffer, what are the values of the two variables I set to nil in the advice function?

rkachach commented 2 years ago

@lebensterben using c-h v I can see that both of them are nil in the vc-diff buffer

whitespace-trailing-regexp is a variable defined in ‘whitespace.el’.
Its value is nil
Original value was "\\([      ]+\\)$"
Local in buffer *vc-diff*; global value is "\\([      ]+\\)$"

  You can customize this variable.

===========

whitespace-style is a variable defined in ‘whitespace.el’.
Its value is nil
Original value was 
(face tabs spaces trailing lines space-before-tab newline indentation empty space-after-tab space-mark tab-mark newline-mark)
Local in buffer *vc-diff*; global value is 
(face tabs spaces trailing lines space-before-tab newline indentation empty space-after-tab space-mark tab-mark newline-mark)
lebensterben commented 2 years ago

@rkachach since they're nil the advice function is running correctly...

rkachach commented 2 years ago

@lebensterben yeah, but as you can see in the capture above the 'show trailing space' is still checked .. and I don't know where this conf is coming from...

lebensterben commented 2 years ago

@rkachach can you post your whole .spacemacs

rkachach commented 2 years ago

sure:

`; -*- mode: emacs-lisp; lexical-binding: t -*-
;; This file is loaded by Spacemacs at startup.
;; It must be stored in your home directory.

(defun dotspacemacs/layers ()
  "Layer configuration:
This function should only modify configuration layer settings."
  (setq-default
   ;; Base distribution to use. This is a layer contained in the directory
   ;; `+distribution'. For now available distributions are `spacemacs-base'
   ;; or `spacemacs'. (default 'spacemacs)
   dotspacemacs-distribution 'spacemacs

   ;; Lazy installation of layers (i.e. layers are installed only when a file
   ;; with a supported type is opened). Possible values are `all', `unused'
   ;; and `nil'. `unused' will lazy install only unused layers (i.e. layers
   ;; not listed in variable `dotspacemacs-configuration-layers'), `all' will
   ;; lazy install any layer that support lazy installation even the layers
   ;; listed in `dotspacemacs-configuration-layers'. `nil' disable the lazy
   ;; installation feature and you have to explicitly list a layer in the
   ;; variable `dotspacemacs-configuration-layers' to install it.
   ;; (default 'unused)
   dotspacemacs-enable-lazy-installation 'unused

   ;; If non-nil then Spacemacs will ask for confirmation before installing
   ;; a layer lazily. (default t)
   dotspacemacs-ask-for-lazy-installation t

   ;; List of additional paths where to look for configuration layers.
   ;; Paths must have a trailing slash (i.e. `~/.mycontribs/')
   dotspacemacs-configuration-layer-path '()

   ;; Redo

   ;; List of configuration layers to load.
   dotspacemacs-configuration-layers
   '(ansible
     javascript
     yaml
     python
     ;; ----------------------------------------------------------------
     ;; Example of useful layers you may want to use right away.
     ;; Uncomment some layer names and press `SPC f e R' (Vim style) or
     ;; `M-m f e R' (Emacs style) to install them.
     ;; ----------------------------------------------------------------
     better-defaults
     emacs-lisp
     git
     helm
     ;;lsp
     ;;markdown
     ;;multiple-cursors
     auto-completion

     c-c++
     (c-c++ :variables
            c-c++-enable-clang-support t
            c-c++-backend 'lsp-clangd)
     org
     shell
     (shell :variables
            shell-default-height 30
            shell-default-position 'bottom)
     ;;spell-checking
     syntax-checking
     version-control
     (version-control :variables
                      version-control-diff-tool 'diff-hl
                      version-control-diff-side 'left
                      version-control-global-margin 't)

     treemacs)

   ;; List of additional packages that will be installed without being wrapped
   ;; in a layer (generally the packages are installed only and should still be
   ;; loaded using load/require/use-package in the user-config section below in
   ;; this file). If you need some configuration for these packages, then
   ;; consider creating a layer. You can also put the configuration in
   ;; `dotspacemacs/user-config'. To use a local version of a package, use the
   ;; `:location' property: '(your-package :location "~/path/to/your-package/")
   ;; Also include the dependencies as they will not be resolved automatically.
   dotspacemacs-additional-packages '(flycheck-mypy diff-hl dockerfile-mode)

   ;; A list of packages that cannot be updated.
   dotspacemacs-frozen-packages '()

   ;; A list of packages that will not be installed and loaded.
   dotspacemacs-excluded-packages '()

   ;; Defines the behaviour of Spacemacs when installing packages.
   ;; Possible values are `used-only', `used-but-keep-unused' and `all'.
   ;; `used-only' installs only explicitly used packages and deletes any unused
   ;; packages as well as their unused dependencies. `used-but-keep-unused'
   ;; installs only the used packages but won't delete unused ones. `all'
   ;; installs *all* packages supported by Spacemacs and never uninstalls them.
   ;; (default is `used-only')
   dotspacemacs-install-packages 'used-only))

(defun dotspacemacs/init ()
  "Initialization:
This function is called at the very beginning of Spacemacs startup,
before layer configuration.
It should only modify the values of Spacemacs settings."
  ;; This setq-default sexp is an exhaustive list of all the supported
  ;; spacemacs settings.
  (setq-default
   ;; If non-nil then enable support for the portable dumper. You'll need
   ;; to compile Emacs 27 from source following the instructions in file
   ;; EXPERIMENTAL.org at to root of the git repository.
   ;; (default nil)
   dotspacemacs-enable-emacs-pdumper nil

   ;; Name of executable file pointing to emacs 27+. This executable must be
   ;; in your PATH.
   ;; (default "emacs")
   dotspacemacs-emacs-pdumper-executable-file "emacs"

   ;; Name of the Spacemacs dump file. This is the file will be created by the
   ;; portable dumper in the cache directory under dumps sub-directory.
   ;; To load it when starting Emacs add the parameter `--dump-file'
   ;; when invoking Emacs 27.1 executable on the command line, for instance:
   ;;   ./emacs --dump-file=$HOME/.emacs.d/.cache/dumps/spacemacs-27.1.pdmp
   ;; (default (format "spacemacs-%s.pdmp" emacs-version))
   dotspacemacs-emacs-dumper-dump-file (format "spacemacs-%s.pdmp" emacs-version)

   ;; If non-nil ELPA repositories are contacted via HTTPS whenever it's
   ;; possible. Set it to nil if you have no way to use HTTPS in your
   ;; environment, otherwise it is strongly recommended to let it set to t.
   ;; This variable has no effect if Emacs is launched with the parameter
   ;; `--insecure' which forces the value of this variable to nil.
   ;; (default t)
   dotspacemacs-elpa-https t

   ;; Maximum allowed time in seconds to contact an ELPA repository.
   ;; (default 5)
   dotspacemacs-elpa-timeout 5

   ;; Set `gc-cons-threshold' and `gc-cons-percentage' when startup finishes.
   ;; This is an advanced option and should not be changed unless you suspect
   ;; performance issues due to garbage collection operations.
   ;; (default '(100000000 0.1))
   dotspacemacs-gc-cons '(100000000 0.1)

   ;; Set `read-process-output-max' when startup finishes.
   ;; This defines how much data is read from a foreign process.
   ;; Setting this >= 1 MB should increase performance for lsp servers
   ;; in emacs 27.
   ;; (default (* 1024 1024))
   dotspacemacs-read-process-output-max (* 1024 1024)

   ;; If non-nil then Spacelpa repository is the primary source to install
   ;; a locked version of packages. If nil then Spacemacs will install the
   ;; latest version of packages from MELPA. Spacelpa is currently in
   ;; experimental state please use only for testing purposes.
   ;; (default nil)
   dotspacemacs-use-spacelpa nil

   ;; If non-nil then verify the signature for downloaded Spacelpa archives.
   ;; (default t)
   dotspacemacs-verify-spacelpa-archives t

   ;; If non-nil then spacemacs will check for updates at startup
   ;; when the current branch is not `develop'. Note that checking for
   ;; new versions works via git commands, thus it calls GitHub services
   ;; whenever you start Emacs. (default nil)
   dotspacemacs-check-for-update nil

   ;; If non-nil, a form that evaluates to a package directory. For example, to
   ;; use different package directories for different Emacs versions, set this
   ;; to `emacs-version'. (default 'emacs-version)
   dotspacemacs-elpa-subdirectory 'emacs-version

   ;; One of `vim', `emacs' or `hybrid'.
   ;; `hybrid' is like `vim' except that `insert state' is replaced by the
   ;; `hybrid state' with `emacs' key bindings. The value can also be a list
   ;; with `:variables' keyword (similar to layers). Check the editing styles
   ;; section of the documentation for details on available variables.
   ;; (default 'vim)
   dotspacemacs-editing-style 'emacs

   ;; If non-nil show the version string in the Spacemacs buffer. It will
   ;; appear as (spacemacs version)@(emacs version)
   ;; (default t)
   dotspacemacs-startup-buffer-show-version t

   ;; Specify the startup banner. Default value is `official', it displays
   ;; the official spacemacs logo. An integer value is the index of text
   ;; banner, `random' chooses a random text banner in `core/banners'
   ;; directory. A string value must be a path to an image format supported
   ;; by your Emacs build.
   ;; If the value is nil then no banner is displayed. (default 'official)
   dotspacemacs-startup-banner 'official

   ;; List of items to show in startup buffer or an association list of
   ;; the form `(list-type . list-size)`. If nil then it is disabled.
   ;; Possible values for list-type are:
   ;; `recents' `recents-by-project' `bookmarks' `projects' `agenda' `todos'.
   ;; List sizes may be nil, in which case
   ;; `spacemacs-buffer-startup-lists-length' takes effect.
   ;; The exceptional case is `recents-by-project', where list-type must be a
   ;; pair of numbers, e.g. `(recents-by-project . (7 .  5))', where the first
   ;; number is the project limit and the second the limit on the recent files
   ;; within a project.
   dotspacemacs-startup-lists '((recents . 5)
                                (projects . 7))

   ;; True if the home buffer should respond to resize events. (default t)
   dotspacemacs-startup-buffer-responsive t

   ;; Show numbers before the startup list lines. (default t)
   dotspacemacs-show-startup-list-numbers t

   ;; The minimum delay in seconds between number key presses. (default 0.4)
   dotspacemacs-startup-buffer-multi-digit-delay 0.4

   ;; Default major mode for a new empty buffer. Possible values are mode
   ;; names such as `text-mode'; and `nil' to use Fundamental mode.
   ;; (default `text-mode')
   dotspacemacs-new-empty-buffer-major-mode 'text-mode

   ;; Default major mode of the scratch buffer (default `text-mode')
   dotspacemacs-scratch-mode 'text-mode

   ;; If non-nil, *scratch* buffer will be persistent. Things you write down in
   ;; *scratch* buffer will be saved and restored automatically.
   dotspacemacs-scratch-buffer-persistent nil

   ;; If non-nil, `kill-buffer' on *scratch* buffer
   ;; will bury it instead of killing.
   dotspacemacs-scratch-buffer-unkillable nil

   ;; Initial message in the scratch buffer, such as "Welcome to Spacemacs!"
   ;; (default nil)
   dotspacemacs-initial-scratch-message nil

   ;; List of themes, the first of the list is loaded when spacemacs starts.
   ;; Press `SPC T n' to cycle to the next theme in the list (works great
   ;; with 2 themes variants, one dark and one light)
   dotspacemacs-themes '(spacemacs-dark
                         spacemacs-light)

   ;; Set the theme for the Spaceline. Supported themes are `spacemacs',
   ;; `all-the-icons', `custom', `doom', `vim-powerline' and `vanilla'. The
   ;; first three are spaceline themes. `doom' is the doom-emacs mode-line.
   ;; `vanilla' is default Emacs mode-line. `custom' is a user defined themes,
   ;; refer to the DOCUMENTATION.org for more info on how to create your own
   ;; spaceline theme. Value can be a symbol or list with additional properties.
   ;; (default '(spacemacs :separator wave :separator-scale 1.5))
   dotspacemacs-mode-line-theme '(spacemacs :separator wave :separator-scale 1.5)

   ;; If non-nil the cursor color matches the state color in GUI Emacs.
   ;; (default t)
   dotspacemacs-colorize-cursor-according-to-state t

   ;; Default font or prioritized list of fonts. The `:size' can be specified as
   ;; a non-negative integer (pixel size), or a floating-point (point size).
   ;; Point size is recommended, because it's device independent. (default 10.0)
   dotspacemacs-default-font '("Source Code Pro"
                               :size 10.0
                               :weight normal
                               :width normal)

   ;; The leader key (default "SPC")
   dotspacemacs-leader-key "SPC"

   ;; The key used for Emacs commands `M-x' (after pressing on the leader key).
   ;; (default "SPC")
   dotspacemacs-emacs-command-key "SPC"

   ;; The key used for Vim Ex commands (default ":")
   dotspacemacs-ex-command-key ":"

   ;; The leader key accessible in `emacs state' and `insert state'
   ;; (default "M-m")
   dotspacemacs-emacs-leader-key "M-m"

   ;; Major mode leader key is a shortcut key which is the equivalent of
   ;; pressing `<leader> m`. Set it to `nil` to disable it. (default ",")
   dotspacemacs-major-mode-leader-key ","

   ;; Major mode leader key accessible in `emacs state' and `insert state'.
   ;; (default "C-M-m" for terminal mode, "<M-return>" for GUI mode).
   ;; Thus M-RET should work as leader key in both GUI and terminal modes.
   ;; C-M-m also should work in terminal mode, but not in GUI mode.
   dotspacemacs-major-mode-emacs-leader-key (if window-system "<M-return>" "C-M-m")

   ;; These variables control whether separate commands are bound in the GUI to
   ;; the key pairs `C-i', `TAB' and `C-m', `RET'.
   ;; Setting it to a non-nil value, allows for separate commands under `C-i'
   ;; and TAB or `C-m' and `RET'.
   ;; In the terminal, these pairs are generally indistinguishable, so this only
   ;; works in the GUI. (default nil)
   dotspacemacs-distinguish-gui-tab nil

   ;; Name of the default layout (default "Default")
   dotspacemacs-default-layout-name "Default"

   ;; If non-nil the default layout name is displayed in the mode-line.
   ;; (default nil)
   dotspacemacs-display-default-layout nil

   ;; If non-nil then the last auto saved layouts are resumed automatically upon
   ;; start. (default nil)
   dotspacemacs-auto-resume-layouts nil

   ;; If non-nil, auto-generate layout name when creating new layouts. Only has
   ;; effect when using the "jump to layout by number" commands. (default nil)
   dotspacemacs-auto-generate-layout-names nil

   ;; Size (in MB) above which spacemacs will prompt to open the large file
   ;; literally to avoid performance issues. Opening a file literally means that
   ;; no major mode or minor modes are active. (default is 1)
   dotspacemacs-large-file-size 1

   ;; Location where to auto-save files. Possible values are `original' to
   ;; auto-save the file in-place, `cache' to auto-save the file to another
   ;; file stored in the cache directory and `nil' to disable auto-saving.
   ;; (default 'cache)
   dotspacemacs-auto-save-file-location 'cache

   ;; Maximum number of rollback slots to keep in the cache. (default 5)
   dotspacemacs-max-rollback-slots 5

   ;; If non-nil, the paste transient-state is enabled. While enabled, after you
   ;; paste something, pressing `C-j' and `C-k' several times cycles through the
   ;; elements in the `kill-ring'. (default nil)
   dotspacemacs-enable-paste-transient-state nil

   ;; Which-key delay in seconds. The which-key buffer is the popup listing
   ;; the commands bound to the current keystroke sequence. (default 0.4)
   dotspacemacs-which-key-delay 0.4

   ;; Which-key frame position. Possible values are `right', `bottom' and
   ;; `right-then-bottom'. right-then-bottom tries to display the frame to the
   ;; right; if there is insufficient space it displays it at the bottom.
   ;; (default 'bottom)
   dotspacemacs-which-key-position 'bottom

   ;; Control where `switch-to-buffer' displays the buffer. If nil,
   ;; `switch-to-buffer' displays the buffer in the current window even if
   ;; another same-purpose window is available. If non-nil, `switch-to-buffer'
   ;; displays the buffer in a same-purpose window even if the buffer can be
   ;; displayed in the current window. (default nil)
   dotspacemacs-switch-to-buffer-prefers-purpose nil

   ;; If non-nil a progress bar is displayed when spacemacs is loading. This
   ;; may increase the boot time on some systems and emacs builds, set it to
   ;; nil to boost the loading time. (default t)
   dotspacemacs-loading-progress-bar t

   ;; If non-nil the frame is fullscreen when Emacs starts up. (default nil)
   ;; (Emacs 24.4+ only)
   dotspacemacs-fullscreen-at-startup t

   ;; If non-nil `spacemacs/toggle-fullscreen' will not use native fullscreen.
   ;; Use to disable fullscreen animations in OSX. (default nil)
   dotspacemacs-fullscreen-use-non-native nil

   ;; If non-nil the frame is maximized when Emacs starts up.
   ;; Takes effect only if `dotspacemacs-fullscreen-at-startup' is nil.
   ;; (default nil) (Emacs 24.4+ only)
   dotspacemacs-maximized-at-startup nil

   ;; If non-nil the frame is undecorated when Emacs starts up. Combine this
   ;; variable with `dotspacemacs-maximized-at-startup' in OSX to obtain
   ;; borderless fullscreen. (default nil)
   dotspacemacs-undecorated-at-startup nil

   ;; A value from the range (0..100), in increasing opacity, which describes
   ;; the transparency level of a frame when it's active or selected.
   ;; Transparency can be toggled through `toggle-transparency'. (default 90)
   dotspacemacs-active-transparency 90

   ;; A value from the range (0..100), in increasing opacity, which describes
   ;; the transparency level of a frame when it's inactive or deselected.
   ;; Transparency can be toggled through `toggle-transparency'. (default 90)
   dotspacemacs-inactive-transparency 90

   ;; If non-nil show the titles of transient states. (default t)
   dotspacemacs-show-transient-state-title t

   ;; If non-nil show the color guide hint for transient state keys. (default t)
   dotspacemacs-show-transient-state-color-guide t

   ;; If non-nil unicode symbols are displayed in the mode line.
   ;; If you use Emacs as a daemon and wants unicode characters only in GUI set
   ;; the value to quoted `display-graphic-p'. (default t)
   dotspacemacs-mode-line-unicode-symbols t

   ;; If non-nil smooth scrolling (native-scrolling) is enabled. Smooth
   ;; scrolling overrides the default behavior of Emacs which recenters point
   ;; when it reaches the top or bottom of the screen. (default t)
   dotspacemacs-smooth-scrolling t

   ;; Show the scroll bar while scrolling. The auto hide time can be configured
   ;; by setting this variable to a number. (default t)
   dotspacemacs-scroll-bar-while-scrolling t

   ;; Control line numbers activation.
   ;; If set to `t', `relative' or `visual' then line numbers are enabled in all
   ;; `prog-mode' and `text-mode' derivatives. If set to `relative', line
   ;; numbers are relative. If set to `visual', line numbers are also relative,
   ;; but only visual lines are counted. For example, folded lines will not be
   ;; counted and wrapped lines are counted as multiple lines.
   ;; This variable can also be set to a property list for finer control:
   ;; '(:relative nil
   ;;   :visual nil
   ;;   :disabled-for-modes dired-mode
   ;;                       doc-view-mode
   ;;                       markdown-mode
   ;;                       org-mode
   ;;                       pdf-view-mode
   ;;                       text-mode
   ;;   :size-limit-kb 1000)
   ;; When used in a plist, `visual' takes precedence over `relative'.
   ;; (default nil)
   dotspacemacs-line-numbers nil

   ;; Code folding method. Possible values are `evil', `origami' and `vimish'.
   ;; (default 'evil)
   dotspacemacs-folding-method 'evil

   ;; If non-nil and `dotspacemacs-activate-smartparens-mode' is also non-nil,
   ;; `smartparens-strict-mode' will be enabled in programming modes.
   ;; (default nil)
   dotspacemacs-smartparens-strict-mode nil

   ;; If non-nil smartparens-mode will be enabled in programming modes.
   ;; (default t)
   dotspacemacs-activate-smartparens-mode t

   ;; If non-nil pressing the closing parenthesis `)' key in insert mode passes
   ;; over any automatically added closing parenthesis, bracket, quote, etc...
   ;; This can be temporary disabled by pressing `C-q' before `)'. (default nil)
   dotspacemacs-smart-closing-parenthesis nil

   ;; Select a scope to highlight delimiters. Possible values are `any',
   ;; `current', `all' or `nil'. Default is `all' (highlight any scope and
   ;; emphasis the current one). (default 'all)
   dotspacemacs-highlight-delimiters 'all

   ;; If non-nil, start an Emacs server if one is not already running.
   ;; (default nil)
   dotspacemacs-enable-server t

   ;; Set the emacs server socket location.
   ;; If nil, uses whatever the Emacs default is, otherwise a directory path
   ;; like \"~/.emacs.d/server\". It has no effect if
   ;; `dotspacemacs-enable-server' is nil.
   ;; (default nil)
   dotspacemacs-server-socket-dir nil

   ;; If non-nil, advise quit functions to keep server open when quitting.
   ;; (default nil)
   dotspacemacs-persistent-server t

   ;; List of search tool executable names. Spacemacs uses the first installed
   ;; tool of the list. Supported tools are `rg', `ag', `pt', `ack' and `grep'.
   ;; (default '("rg" "ag" "pt" "ack" "grep"))
   dotspacemacs-search-tools '("rg" "ag" "pt" "ack" "grep")

   ;; Format specification for setting the frame title.
   ;; %a - the `abbreviated-file-name', or `buffer-name'
   ;; %t - `projectile-project-name'
   ;; %I - `invocation-name'
   ;; %S - `system-name'
   ;; %U - contents of $USER
   ;; %b - buffer name
   ;; %f - visited file name
   ;; %F - frame name
   ;; %s - process status
   ;; %p - percent of buffer above top of window, or Top, Bot or All
   ;; %P - percent of buffer above bottom of window, perhaps plus Top, or Bot or All
   ;; %m - mode name
   ;; %n - Narrow if appropriate
   ;; %z - mnemonics of buffer, terminal, and keyboard coding systems
   ;; %Z - like %z, but including the end-of-line format
   ;; If nil then Spacemacs uses default `frame-title-format' to avoid
   ;; performance issues, instead of calculating the frame title by
   ;; `spacemacs/title-prepare' all the time.
   ;; (default "%I@%S")
   dotspacemacs-frame-title-format "%I@%S"

   ;; Format specification for setting the icon title format
   ;; (default nil - same as frame-title-format)
   dotspacemacs-icon-title-format nil

   ;; Show trailing whitespace (default t)
   dotspacemacs-show-trailing-whitespace nil

   ;; Delete whitespace while saving buffer. Possible values are `all'
   ;; to aggressively delete empty line and long sequences of whitespace,
   ;; `trailing' to delete only the whitespace at end of lines, `changed' to
   ;; delete only whitespace for changed lines or `nil' to disable cleanup.
   ;; (default nil)
   dotspacemacs-whitespace-cleanup nil

   ;; If non-nil activate `clean-aindent-mode' which tries to correct
   ;; virtual indentation of simple modes. This can interfere with mode specific
   ;; indent handling like has been reported for `go-mode'.
   ;; If it does deactivate it here.
   ;; (default t)
   dotspacemacs-use-clean-aindent-mode t

   ;; Accept SPC as y for prompts if non-nil. (default nil)
   dotspacemacs-use-SPC-as-y nil

   ;; If non-nil shift your number row to match the entered keyboard layout
   ;; (only in insert state). Currently supported keyboard layouts are:
   ;; `qwerty-us', `qwertz-de' and `querty-ca-fr'.
   ;; New layouts can be added in `spacemacs-editing' layer.
   ;; (default nil)
   dotspacemacs-swap-number-row nil

   ;; Either nil or a number of seconds. If non-nil zone out after the specified
   ;; number of seconds. (default nil)
   dotspacemacs-zone-out-when-idle nil

   ;; Run `spacemacs/prettify-org-buffer' when
   ;; visiting README.org files of Spacemacs.
   ;; (default nil)
   dotspacemacs-pretty-docs nil

   ;; If nil the home buffer shows the full path of agenda items
   ;; and todos. If non-nil only the file name is shown.
   dotspacemacs-home-shorten-agenda-source nil

   ;; If non-nil then byte-compile some of Spacemacs files.
   dotspacemacs-byte-compile nil))

(defun dotspacemacs/user-env ()
  "Environment variables setup.
This function defines the environment variables for your Emacs session. By
default it calls `spacemacs/load-spacemacs-env' which loads the environment
variables declared in `~/.spacemacs.env' or `~/.spacemacs.d/.spacemacs.env'.
See the header of this file for more information."
  (spacemacs/load-spacemacs-env)
)

(defun dotspacemacs/user-init ()
  "Initialization for user code:
This function is called immediately after `dotspacemacs/init', before layer
configuration.
It is mostly for variables that should be set before packages are loaded.
If you are unsure, try setting them in `dotspacemacs/user-config' first."
  (setq-default dotspacemacs-themes '(monokai))
)

(defun dotspacemacs/user-load ()
  "Library to load while dumping.
This function is called only while dumping Spacemacs configuration. You can
`require' or `load' the libraries of your choice that will be included in the
dump."
)

(defun dotspacemacs/user-config ()
  "Configuration for user code:
This function is called at the very end of Spacemacs startup, after layer
configuration.
Put your configuration code here, except for variables that should be set
before packages are loaded."
  (with-eval-after-load 'evil
    (define-key evil-emacs-state-map (kbd "C-z") nil))

  (global-company-mode t)

  (require 'diff-hl)
  (require 'flycheck-mypy)
  (diff-hl-flydiff-mode '(:global t))
  (diff-hl-margin-mode '(:global t))

  ;;(spacemacs/toggle-indent-guide-globally-on)

  ;;(flycheck-define-checker
  ;;    python-mypy ""
  ;;    :command ("mypy"
  ;;              "--ignore-missing-imports"
  ;;              "--python-version" "3.6"
  ;;              source-original)
  ;;    :error-patterns
  ;;    ((error line-start (file-name) ":" line ": error:" (message) line-end))
  ;;    :modes python-mode)
  ;;(add-to-list 'flycheck-checkers 'python-mypy t)
  ;;(flycheck-add-next-checker 'python-mypy t)
  ;;(setq flycheck-python-pycompile-executable "/usr/bin/python3")
  ;; 
  (setq show-trailing-whitespace nil)
  (setq spacemacs-show-trailing-whitespace nil)
  (setq-local whitespace-style nil)
  (setq-local whitespace-trailing-regexp nil)

  (advice-add 'vc-diff-finish
              :after (lambda (_buffer _message)
                       (setq-local whitespace-style nil)
                       (setq-local whitespace-trailing-regexp nil)))
  )

;; Do not write anything past this comment. This is where Emacs will
;; auto-generate custom variable definitions.
(defun dotspacemacs/emacs-custom-settings ()
  "Emacs custom settings.
This is an auto-generated function, do not modify its content directly, use
Emacs customize menu instead.
This function is called at the very end of Spacemacs initialization."
(custom-set-variables
 ;; custom-set-variables was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(evil-want-Y-yank-to-eol nil)
 '(flycheck-checker-error-threshold 500)
 '(package-selected-packages
   '(projectile ethan-wspace jinja2-mode company-ansible ansible-doc ansible add-node-modules-path yaml-mode dockerfile-mode diff-hl monokai-theme yapfify stickyfunc-enhance sphinx-doc pytest pyenv-mode pydoc py-isort poetry transient pippel pipenv pyvenv pip-requirements nose lsp-python-ms lsp-pyright live-py-mode importmagic epc ctable concurrent deferred helm-pydoc helm-gtags helm-cscope xcscope ggtags dap-mode lsp-treemacs bui lsp-mode markdown-mode cython-mode counsel-gtags counsel swiper ivy company-anaconda company blacken anaconda-mode pythonic ws-butler writeroom-mode winum which-key volatile-highlights vi-tilde-fringe uuidgen use-package undo-tree treemacs-projectile treemacs-persp treemacs-icons-dired toc-org symon symbol-overlay string-inflection string-edit spaceline-all-the-icons restart-emacs request rainbow-delimiters quickrun popwin pcre2el password-generator paradox overseer org-superstar open-junk-file nameless multi-line macrostep lorem-ipsum link-hint inspector info+ indent-guide hybrid-mode hungry-delete hl-todo highlight-parentheses highlight-numbers highlight-indentation helm-xref helm-themes helm-swoop helm-purpose helm-projectile helm-org helm-mode-manager helm-make helm-ls-git helm-flx helm-descbinds helm-ag google-translate golden-ratio font-lock+ flycheck-package flycheck-elsa flx-ido fancy-battery eyebrowse expand-region evil-visualstar evil-visual-mark-mode evil-unimpaired evil-tutor evil-textobj-line evil-surround evil-numbers evil-nerd-commenter evil-mc evil-matchit evil-lisp-state evil-lion evil-indent-plus evil-iedit-state evil-goggles evil-exchange evil-escape evil-ediff evil-collection evil-cleverparens evil-args evil-anzu eval-sexp-fu emr elisp-slime-nav editorconfig dumb-jump drag-stuff dotenv-mode dired-quick-sort diminish devdocs define-word column-enforce-mode clean-aindent-mode centered-cursor-mode auto-highlight-symbol auto-compile aggressive-indent ace-link ace-jump-helm-line))
 '(show-trailing-whitespace nil))
(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(iedit-occurrence ((t (:inherit highlight :background "orange red"))))
 '(isearch ((t (:background "yellow" :foreground "forest green"))))
 '(lazy-highlight ((t (:background "yellow" :foreground "forest green" :inverse-video nil)))))
)
lebensterben commented 2 years ago

@rkachach Try to replace the advice with a new one:

(defun my-vc-diff-finish (buffer messages)
  ;; The empty sync output case has already been handled, so the only
  ;; possibility of an empty output is for an async process.
  (when (buffer-live-p buffer)
    (let ((window (get-buffer-window buffer t))
      (emptyp (zerop (buffer-size buffer))))
      (with-current-buffer buffer
    (and messages emptyp
         (let ((inhibit-read-only t))
           (insert (cdr messages) ".\n")
           (message "%s" (cdr messages))))
  (setq-local whitespace-style nil)
  (setq-local whitespace-trailing-regexp nil)
    (goto-char (point-min))
    (when window
      (shrink-window-if-larger-than-buffer window)))
      (when (and messages (not emptyp))
    (message "%sdone" (car messages))))))

(advice-add 'vc-diff-finish :override #'my-vc-diff-finish)

A few unrelated stuff:

You have

     c-c++
     (c-c++ :variables
            c-c++-enable-clang-support t
            c-c++-backend 'lsp-clangd)

You only need (c-c++ :variables ..) and can delete the c-c++. The same apply for version-control and any other layers.

Also, you can comment out

  (setq show-trailing-whitespace nil)
  (setq spacemacs-show-trailing-whitespace nil)
  (setq-local whitespace-style nil)
  (setq-local whitespace-trailing-regexp nil)

They should not have any effect. Otherwise there's something wrong.

rkachach commented 2 years ago

@lebensterben thank you very much for taking time to look into this and for the recommendations. Unfortunately the problem still persists and I still see the "dots" :(

lebensterben commented 2 years ago

@rkachach

I'm a bit confused here. What I showed you above is to prevent trailing whitespaces being highlighted, not to prevent them from being shown as a dot.

Are they still highlighted?

rkachach commented 2 years ago

mmm maybe I didn't explain myself clearly (my bad). My issue is with the "dots" that are shown. If you see the above captures you can see my desired output (without dots). Actually I don't mind if they are highlighted or not, what I'm trying to hide are the dots used to mark the spaces.

Sorry about the confusion

lebensterben commented 2 years ago

@rkachach Okay I will investigate. You can safely remove those advice functions.

rkachach commented 2 years ago

Ok, thank you very much :+1:

lebensterben commented 2 years ago

@rkachach Try this

(advice-add 'vc-diff-finish :after (lambda (_buffer _message) (whitespace-mode -1)))
rkachach commented 2 years ago

@lebensterben it doesn't seem to have any effect. whitespace-mode is still enabled. If I disabled it manually (M-x) then it works. Even in this case, when I re-run the vc-diff manually it seems to be re-enabled again. I think the vc-diff doesn't care about any configuration and always enable the whitespace-mode :(

lebensterben commented 2 years ago

@rkachach have you restarted Emacs? because with this advice not only the dots disappeared, so did the highlighting of trailing spaces.

rkachach commented 2 years ago

@lebensterben Yeah, several times (I always close Emacs when performing changes in the conf just in case). The case is that even when I disable the white-space mode manually it's re-enabled once I launch some vc-diff (it seems that this mode is enabling that mode always during its startup).

tg-cea commented 1 year ago

Hello,

Adding the line :

(setq dotspacemacs-show-trailing-whitespace nil)

to the user-config section did work for me.

Hope this helps!

catern commented 12 months ago

The dots used to mark whitespace in diff-mode are caused by a Spacemacs customization. You can disable it with:

(remove-hook 'diff-mode-hook 'spacemacs//set-whitespace-style-for-diff)

Probably this customization should be removed altogether, since it's incredibly ugly and basically useless.