syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.64k stars 4.89k forks source link

orgmode H and L mapping should be removed #4645

Closed maxigit closed 8 years ago

maxigit commented 8 years ago

In orgmode H and L are mapped to start and end of line. This conflict with normal vim behavior (and therefore other mode) where H and L go at the top and bottom of the page. Moreover, these mapping are unnecessary as the same can already by achieved with ^,0 and $. Unless I'm missing something ...

tboby commented 8 years ago

Perhaps it's a frequency thing? I find it's really important to use org-beginning-of-line and org-end-of-line before code motion/structure editing in orgmode. $ and ^ aren't particularly comfortable to use and I go to beginning and end of line far more than beginning and end of the buffer.

Something like avy is better for moving around the current window isn't it?

maxigit commented 8 years ago

Why do you go at the beginning and line for ? If it's to edit the line, then just use A and I. Anyway, I'm sure you have your reason, I just think having that as a default is a not good thing as it breaks existing key-binding. If you really need those mapping can't you just set them in your configuration file ?

On 17 January 2016 at 14:40, tboby notifications@github.com wrote:

Perhaps it's a frequency thing? I find it's really important to use org-beginning-of-line and org-end-of-line before code motion/structure editing in orgmode. $ and ^ aren't particularly easy to use and I go to beginning and end of line far more than beginning and end of document.

— Reply to this email directly or view it on GitHub https://github.com/syl20bnr/spacemacs/issues/4645#issuecomment-172330083 .

tboby commented 8 years ago

I didn't set the bindings, I'm just speculating.

Because org end of line and visual character end of line are not the same. In evil-org-mode it's probably more important that org-mode works properly with default keybinds.

maxigit commented 8 years ago

I understand that the begining and end of line needs to be tweaked for orgmode which is why ^ and $ are already set to org-beginning-of-line and org-end-of-line. I don't think there is a need to double it up to H and L. (If people feel the need to map H and L to ^ and $ then they should feel it not only for orgmode but every mode and set it in their personal preferences).

On 17 January 2016 at 20:21, tboby notifications@github.com wrote:

I didn't set the bindings, I'm just speculating.

Because org end of line and visual character end of line are not the same. In evil-org-mode it's probably more important that org-mode works properly with default keybinds.

— Reply to this email directly or view it on GitHub https://github.com/syl20bnr/spacemacs/issues/4645#issuecomment-172377039 .

TheBB commented 8 years ago

I tend to agree with @maxigit. However I don't see that 0, ^ and $ are rebound to anything org-specific. If we can do that I'm all for removing H and L.

what-the-functor commented 8 years ago

evil-org-mode provides the following bindings: ’$’ org-end-of-line ’^’ org-beginning-of-line

choppsv1 commented 8 years ago

+1. "H" and "L" have specific vi motions that I (and presumably many other vi users) are quite used to and aren't anywhere near beginning of line or end of line, they are top of window and bottom of window. Remapping these to motions that already have keys associated with them seems like a user specific mapping by the package author, who must not normally use H and L. We should remove these odd remappings in spacemacs and be true to vi.

jb55 commented 8 years ago

Yeah he even went further and rebound J and K awhile back which we reverted. This seem like the author's personal bindings creeping into his library. :+1: for remove.