search

syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.69k stars 4.9k forks source link

Non-logical comint/shell/repl history keybindings? #5096

Closed olejorgenb closed 8 years ago

olejorgenb commented 8 years ago

We all agree that: k = up j = down

If this is what I've typed in the repl:

entry1 entry2 entry3

I would expect that k should revive entry3, not entry1, right?

But the default keybindings are:

 (evil-define-key 'insert comint-mode-map
    (kbd "C-k") 'comint-next-input
    (kbd "C-j") 'comint-previous-input)
  (evil-define-key 'normal comint-mode-map
    (kbd "C-k") 'comint-next-input
    (kbd "C-j") 'comint-previous-input)

so what actually happens when I press C-k is that I get entry1 back.

Is this actually intended? (probably not judging from https://github.com/syl20bnr/spacemacs/search?utf8=%E2%9C%93&q=comint-next-input)

All other shells and repls uses the convention that up/previous moves up in the history list.

C-p in bash and others, k in zsh's vi emulation (in normal mode),

in bash ...
bmag commented 8 years ago

Wow, I didn't even notice this until now because I'm used to M-n and M-p. I think it's a bug.

AlejandroCatalina commented 8 years ago

Anyone addressing this one?

bmag commented 8 years ago

I can address this one tomorrow unless @olejorgenb wants to make a PR himself/herself

olejorgenb commented 8 years ago

@bmag I can do it. Not very efficient of course, but it's a nice excuse to get acquainted with the dev process :) (if I'm not done by sunday it's up for grabs though)

d12frosted commented 8 years ago

Fixed with released of Spacemacs v0.200. Let us know if you still have any problems with this issue.