Startup error when dotspacemacs-smooth-scrolling is nil

[madand]

Description

Initialization error pops up when dotspacemacs-smooth-scrolling is set to nil.

I used the mentioned setting for a while with no issues. Now, I have the same issue on my two Arch Linux machines.

Also tried to delete the elpa dir, but with no success in this case.

Reproduction guide

• Set dotspacemacs-smooth-scrolling to nil
• Start Emacs

Observed behaviour: Initialization error: ad-disable-advice: `previous-line' is not advised

Expected behaviour: Normal startup.

System Info

• OS: gnu/linux
• Emacs: 24.5.1
• Spacemacs: 0.105.11
• Spacemacs branch: develop (rev. 85fa271)
• Graphic display: t
• Distribution: spacemacs
• Editing style: vim
• Completion: helm
• Layers:

((auto-completion :variables auto-completion-complete-with-key-sequence "ht" auto-completion-complete-with-key-sequence-delay 0.2 auto-completion-enable-sort-by-usage t)
 clojure
 (colors :variables colors-enable-rainbow-identifiers t)
 emacs-lisp emoji erc evil-commentary eyebrowse fasd finance
 (git :variables git-magit-status-fullscreen t)
 (ibuffer :variables ibuffer-group-buffers-by 'projects)
 javascript haskell html lua markdown org pandoc php
 (python :variables python-enable-yapf-format-on-save t)
 ruby search-engine
 (shell :variables shell-default-height 30 shell-default-position 'bottom)
 spell-checking
 (syntax-checking :variables syntax-checking-enable-tooltips nil)
 sql vagrant version-control xkcd)

Backtrace

Debugger entered--Lisp error: (error "ad-disable-advice: `previous-line' is not advised")
  signal(error ("ad-disable-advice: `previous-line' is not advised"))
  error("ad-disable-advice: `%s' is not advised" previous-line)
  ad-disable-advice(previous-line after smooth-scroll-down)
  (if dotspacemacs-smooth-scrolling nil (ad-disable-advice (quote previous-line) (quote after) (quote smooth-scroll-down)) (ad-activate (quote previous-line)) (ad-disable-advice (quote next-line) (quote after) (quote smooth-scroll-up)) (ad-activate (quote next-line)) (ad-disable-advice (quote isearch-repeat) (quote after) (quote isearch-smooth-scroll)) (ad-activate (quote isearch-repeat)))
  spacemacs-ui-visual/init-smooth-scrolling()
  funcall(spacemacs-ui-visual/init-smooth-scrolling)
  (let* ((pkg-name (eieio-oref pkg (quote :name))) (owner (eieio-oref pkg (quote :owner))) (owner-layer (object-assoc owner :name configuration-layer--layers)) (disabled-for-layers (eieio-oref owner-layer (quote :disabled-for)))) (spacemacs-buffer/message (format "Configuring %S..." pkg-name)) (mapc (function (lambda (layer) (if (memq layer disabled-for-layers) (spacemacs-buffer/message (format "  -> ignored pre-init (%S)..." layer)) (spacemacs-buffer/message (format "  -> pre-init (%S)..." layer)) (condition-case err (funcall (intern ...)) ((debug quote error) (configuration-layer//increment-error-count) (spacemacs-buffer/append ...)))))) (eieio-oref pkg (quote :pre-layers))) (spacemacs-buffer/message (format "  -> init (%S)..." owner)) (funcall (intern (format "%S/init-%S" owner pkg-name))) (mapc (function (lambda (layer) (if (memq layer disabled-for-layers) (spacemacs-buffer/message (format "  -> ignored post-init (%S)..." layer)) (spacemacs-buffer/message (format "  -> post-init (%S)..." layer)) (condition-case err (funcall (intern ...)) ((debug quote error) (configuration-layer//increment-error-count) (spacemacs-buffer/append ...)))))) (eieio-oref pkg (quote :post-layers))))
  configuration-layer//configure-package([object cfgl-package "smooth-scrolling" smooth-scrolling spacemacs-ui-visual nil (shell erc) elpa t nil nil nil nil])
  (cond ((eq (quote dotfile) (eieio-oref pkg (quote :owner))) (spacemacs-buffer/message (format "%S is configured in the dotfile." pkg-name))) (t (configuration-layer//configure-package pkg)))
  (cond ((and (eieio-oref pkg (quote :excluded)) (not (eieio-oref pkg (quote :protected)))) (spacemacs-buffer/message (format "%S ignored since it has been excluded." pkg-name))) ((null (eieio-oref pkg (quote :owner))) (spacemacs-buffer/message (format "%S ignored since it has no owner layer." pkg-name))) ((not (cfgl-package-enabledp pkg)) (spacemacs-buffer/message (format "%S is toggled off." pkg-name))) (t (let ((location (eieio-oref pkg (quote :location)))) (cond ((stringp location) (if (file-directory-p location) (setq load-path (cons ... load-path)) (spacemacs-buffer/warning "Location path for package %S does not exists (value: %s)." pkg location))) ((and (eq (quote local) location) (eq (quote dotfile) (eieio-oref pkg ...))) (setq load-path (cons (file-name-as-directory ...) load-path))) ((eq (quote local) location) (let* ((owner ...) (dir ...)) (setq load-path (cons ... load-path)))))) (if (memq (eieio-oref pkg (quote :location)) (quote (local site built-in))) nil (configuration-layer//activate-package pkg-name)) (cond ((eq (quote dotfile) (eieio-oref pkg (quote :owner))) (spacemacs-buffer/message (format "%S is configured in the dotfile." pkg-name))) (t (configuration-layer//configure-package pkg)))))
  (let ((pkg-name (eieio-oref pkg (quote :name)))) (cond ((and (eieio-oref pkg (quote :excluded)) (not (eieio-oref pkg (quote :protected)))) (spacemacs-buffer/message (format "%S ignored since it has been excluded." pkg-name))) ((null (eieio-oref pkg (quote :owner))) (spacemacs-buffer/message (format "%S ignored since it has no owner layer." pkg-name))) ((not (cfgl-package-enabledp pkg)) (spacemacs-buffer/message (format "%S is toggled off." pkg-name))) (t (let ((location (eieio-oref pkg (quote :location)))) (cond ((stringp location) (if (file-directory-p location) (setq load-path ...) (spacemacs-buffer/warning "Location path for package %S does not exists (value: %s)." pkg location))) ((and (eq ... location) (eq ... ...)) (setq load-path (cons ... load-path))) ((eq (quote local) location) (let* (... ...) (setq load-path ...))))) (if (memq (eieio-oref pkg (quote :location)) (quote (local site built-in))) nil (configuration-layer//activate-package pkg-name)) (cond ((eq (quote dotfile) (eieio-oref pkg (quote :owner))) (spacemacs-buffer/message (format "%S is configured in the dotfile." pkg-name))) (t (configuration-layer//configure-package pkg))))))
  (while --dolist-tail-- (setq pkg (car --dolist-tail--)) (spacemacs-buffer/loading-animation) (let ((pkg-name (eieio-oref pkg (quote :name)))) (cond ((and (eieio-oref pkg (quote :excluded)) (not (eieio-oref pkg (quote :protected)))) (spacemacs-buffer/message (format "%S ignored since it has been excluded." pkg-name))) ((null (eieio-oref pkg (quote :owner))) (spacemacs-buffer/message (format "%S ignored since it has no owner layer." pkg-name))) ((not (cfgl-package-enabledp pkg)) (spacemacs-buffer/message (format "%S is toggled off." pkg-name))) (t (let ((location (eieio-oref pkg ...))) (cond ((stringp location) (if ... ... ...)) ((and ... ...) (setq load-path ...)) ((eq ... location) (let* ... ...)))) (if (memq (eieio-oref pkg (quote :location)) (quote (local site built-in))) nil (configuration-layer//activate-package pkg-name)) (cond ((eq (quote dotfile) (eieio-oref pkg ...)) (spacemacs-buffer/message (format "%S is configured in the dotfile." pkg-name))) (t (configuration-layer//configure-package pkg)))))) (setq --dolist-tail-- (cdr --dolist-tail--)))
  (let ((--dolist-tail-- packages) pkg) (while --dolist-tail-- (setq pkg (car --dolist-tail--)) (spacemacs-buffer/loading-animation) (let ((pkg-name (eieio-oref pkg (quote :name)))) (cond ((and (eieio-oref pkg (quote :excluded)) (not (eieio-oref pkg ...))) (spacemacs-buffer/message (format "%S ignored since it has been excluded." pkg-name))) ((null (eieio-oref pkg (quote :owner))) (spacemacs-buffer/message (format "%S ignored since it has no owner layer." pkg-name))) ((not (cfgl-package-enabledp pkg)) (spacemacs-buffer/message (format "%S is toggled off." pkg-name))) (t (let ((location ...)) (cond (... ...) (... ...) (... ...))) (if (memq (eieio-oref pkg ...) (quote ...)) nil (configuration-layer//activate-package pkg-name)) (cond ((eq ... ...) (spacemacs-buffer/message ...)) (t (configuration-layer//configure-package pkg)))))) (setq --dolist-tail-- (cdr --dolist-tail--))))
  configuration-layer//configure-packages-2(([object cfgl-package "ac-ispell" ac-ispell auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "ace-jump-helm-line" ace-jump-helm-line spacemacs-helm nil nil elpa t nil nil nil nil] [object cfgl-package "ace-link" ace-link spacemacs-ui nil nil elpa t nil nil nil nil] [object cfgl-package "ace-window" ace-window spacemacs-ui nil nil elpa t nil nil nil nil] [object cfgl-package "adaptive-wrap" adaptive-wrap spacemacs-editing-visual nil nil elpa t nil nil nil nil] [object cfgl-package "aggressive-indent" aggressive-indent spacemacs-editing nil nil elpa t nil nil nil nil] [object cfgl-package "anaconda-mode" anaconda-mode python nil nil elpa t nil nil nil nil] [object cfgl-package "auto-compile" auto-compile emacs-lisp nil nil elpa t nil nil nil nil] [object cfgl-package "auto-complete" auto-complete auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "auto-dictionary" auto-dictionary spell-checking nil nil elpa t nil nil nil nil] [object cfgl-package "auto-highlight-symbol" auto-highlight-symbol spacemacs-editing-visual nil nil elpa t nil nil nil nil] [object cfgl-package "auto-yasnippet" auto-yasnippet auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "avy" avy spacemacs-editing nil nil elpa t nil nil nil nil] [object cfgl-package "bind-key" bind-key spacemacs-base nil nil elpa t nil nil nil nil] [object cfgl-package "bookmark" bookmark spacemacs-base nil nil elpa t nil nil nil nil] [object cfgl-package "bracketed-paste" bracketed-paste spacemacs-editing nil nil elpa t nil nil nil nil] [object cfgl-package "buffer-move" buffer-move spacemacs-ui nil nil elpa t nil nil nil nil] [object cfgl-package "bundler" bundler ruby nil nil elpa t nil nil nil nil] [object cfgl-package "centered-cursor" centered-cursor spacemacs-ui nil nil local t nil nil nil nil] [object cfgl-package "chruby" chruby ruby nil nil elpa t nil nil nil nil] [object cfgl-package "cider" cider clojure nil nil elpa t nil nil nil nil] [object cfgl-package "cider-eval-sexp-fu" cider-eval-sexp-fu clojure nil nil elpa t nil nil nil nil] [object cfgl-package "clean-aindent-mode" clean-aindent-mode spacemacs-editing nil nil elpa t nil nil nil nil] [object cfgl-package "clj-refactor" clj-refactor clojure nil nil elpa t nil nil nil nil] [object cfgl-package "clojure-mode" clojure-mode clojure nil nil elpa t nil nil nil nil] [object cfgl-package "cmm-mode" cmm-mode haskell nil nil elpa t nil nil nil nil] [object cfgl-package "coffee-mode" coffee-mode javascript nil nil elpa t nil nil nil nil] [object cfgl-package "comint" comint shell nil nil built-in t nil nil nil nil] [object cfgl-package "company" company auto-completion (shell) (ruby python php org markdown lua html haskell javascript finance erc emacs-lisp clojure) elpa t nil nil nil nil] [object cfgl-package "company-anaconda" company-anaconda python nil nil elpa t nil nil nil nil] [object cfgl-package "company-cabal" company-cabal haskell nil nil elpa t nil nil nil nil] [object cfgl-package "company-emoji" company-emoji emoji nil (org markdown erc) elpa t nil nil nil nil] [object cfgl-package "company-ghc" company-ghc haskell nil nil elpa t nil nil nil nil] [object cfgl-package "company-quickhelp" company-quickhelp auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "company-statistics" company-statistics auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "company-tern" company-tern javascript nil nil elpa t nil nil nil nil] [object cfgl-package "company-web" company-web html nil nil elpa t nil nil nil nil] [object cfgl-package "css-mode" css-mode html nil nil elpa t nil nil nil nil] [object cfgl-package "cython-mode" cython-mode python nil nil elpa t nil nil nil nil] [object cfgl-package "define-word" define-word spacemacs-language nil nil elpa t nil nil nil nil] [object cfgl-package "desktop" desktop spacemacs-ui nil nil elpa t nil nil nil nil] [object cfgl-package "diff-hl" diff-hl version-control nil nil elpa t nil nil nil nil] [object cfgl-package "diff-mode" diff-mode version-control nil nil elpa t nil nil nil nil] [object cfgl-package "diminish" diminish spacemacs-base nil nil elpa t nil nil nil nil] [object cfgl-package "doc-view" doc-view spacemacs-ui nil nil built-in t nil nil nil nil] [object cfgl-package "drupal-mode" drupal-mode php nil nil elpa t nil nil nil nil] [object cfgl-package "ediff" ediff spacemacs-base nil nil elpa t nil nil nil nil] [object cfgl-package "editorconfig" editorconfig dotfile nil nil elpa t nil nil nil nil] [object cfgl-package "eldoc" eldoc spacemacs-base nil (python php emacs-lisp) elpa t nil nil nil nil] [object cfgl-package "electric-indent-mode" electric-indent-mode spacemacs-base nil nil built-in t nil nil nil nil] ...))
  configuration-layer//configure-packages(([object cfgl-package "ac-ispell" ac-ispell auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "ace-jump-helm-line" ace-jump-helm-line spacemacs-helm nil nil elpa t nil nil nil nil] [object cfgl-package "ace-link" ace-link spacemacs-ui nil nil elpa t nil nil nil nil] [object cfgl-package "ace-window" ace-window spacemacs-ui nil nil elpa t nil nil nil nil] [object cfgl-package "adaptive-wrap" adaptive-wrap spacemacs-editing-visual nil nil elpa t nil nil nil nil] [object cfgl-package "aggressive-indent" aggressive-indent spacemacs-editing nil nil elpa t nil nil nil nil] [object cfgl-package "anaconda-mode" anaconda-mode python nil nil elpa t nil nil nil nil] [object cfgl-package "auto-compile" auto-compile emacs-lisp nil nil elpa t nil nil nil nil] [object cfgl-package "auto-complete" auto-complete auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "auto-dictionary" auto-dictionary spell-checking nil nil elpa t nil nil nil nil] [object cfgl-package "auto-highlight-symbol" auto-highlight-symbol spacemacs-editing-visual nil nil elpa t nil nil nil nil] [object cfgl-package "auto-yasnippet" auto-yasnippet auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "avy" avy spacemacs-editing nil nil elpa t nil nil nil nil] [object cfgl-package "bind-key" bind-key spacemacs-base nil nil elpa t nil nil nil nil] [object cfgl-package "bind-map" bind-map spacemacs-base nil nil elpa t pre nil nil nil] [object cfgl-package "bookmark" bookmark spacemacs-base nil nil elpa t nil nil nil nil] [object cfgl-package "bracketed-paste" bracketed-paste spacemacs-editing nil nil elpa t nil nil nil nil] [object cfgl-package "buffer-move" buffer-move spacemacs-ui nil nil elpa t nil nil nil nil] [object cfgl-package "bundler" bundler ruby nil nil elpa t nil nil nil nil] [object cfgl-package "centered-cursor" centered-cursor spacemacs-ui nil nil local t nil nil nil nil] [object cfgl-package "chruby" chruby ruby nil nil elpa t nil nil nil nil] [object cfgl-package "cider" cider clojure nil nil elpa t nil nil nil nil] [object cfgl-package "cider-eval-sexp-fu" cider-eval-sexp-fu clojure nil nil elpa t nil nil nil nil] [object cfgl-package "clean-aindent-mode" clean-aindent-mode spacemacs-editing nil nil elpa t nil nil nil nil] [object cfgl-package "clj-refactor" clj-refactor clojure nil nil elpa t nil nil nil nil] [object cfgl-package "clojure-mode" clojure-mode clojure nil nil elpa t nil nil nil nil] [object cfgl-package "cmm-mode" cmm-mode haskell nil nil elpa t nil nil nil nil] [object cfgl-package "coffee-mode" coffee-mode javascript nil nil elpa t nil nil nil nil] [object cfgl-package "comint" comint shell nil nil built-in t nil nil nil nil] [object cfgl-package "company" company auto-completion (shell) (ruby python php org markdown lua html haskell javascript finance erc emacs-lisp clojure) elpa t nil nil nil nil] [object cfgl-package "company-anaconda" company-anaconda python nil nil elpa t nil nil nil nil] [object cfgl-package "company-cabal" company-cabal haskell nil nil elpa t nil nil nil nil] [object cfgl-package "company-emoji" company-emoji emoji nil (org markdown erc) elpa t nil nil nil nil] [object cfgl-package "company-ghc" company-ghc haskell nil nil elpa t nil nil nil nil] [object cfgl-package "company-quickhelp" company-quickhelp auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "company-statistics" company-statistics auto-completion nil nil elpa t nil nil nil nil] [object cfgl-package "company-tern" company-tern javascript nil nil elpa t nil nil nil nil] [object cfgl-package "company-web" company-web html nil nil elpa t nil nil nil nil] [object cfgl-package "css-mode" css-mode html nil nil elpa t nil nil nil nil] [object cfgl-package "cython-mode" cython-mode python nil nil elpa t nil nil nil nil] [object cfgl-package "define-word" define-word spacemacs-language nil nil elpa t nil nil nil nil] [object cfgl-package "desktop" desktop spacemacs-ui nil nil elpa t nil nil nil nil] [object cfgl-package "diff-hl" diff-hl version-control nil nil elpa t nil nil nil nil] [object cfgl-package "diff-mode" diff-mode version-control nil nil elpa t nil nil nil nil] [object cfgl-package "diminish" diminish spacemacs-base nil nil elpa t nil nil nil nil] [object cfgl-package "doc-view" doc-view spacemacs-ui nil nil built-in t nil nil nil nil] [object cfgl-package "drupal-mode" drupal-mode php nil nil elpa t nil nil nil nil] [object cfgl-package "ediff" ediff spacemacs-base nil nil elpa t nil nil nil nil] [object cfgl-package "editorconfig" editorconfig dotfile nil nil elpa t nil nil nil nil] [object cfgl-package "eldoc" eldoc spacemacs-base nil (python php emacs-lisp) elpa t nil nil nil nil] ...))
  configuration-layer/sync()
  (if (not (version<= spacemacs-emacs-min-version emacs-version)) (message (concat "Your version of Emacs (%s) is too old. " "Spacemacs requires Emacs version %d or above.") emacs-version spacemacs-emacs-min-version) (load-file (concat user-emacs-directory "core/core-load-paths.el")) (require (quote core-spacemacs)) (spacemacs/init) (spacemacs/maybe-install-dotfile) (configuration-layer/sync) (spacemacs/setup-startup-hook) (require (quote server)) (if (server-running-p) nil (server-start)))
  eval-buffer(#<buffer  *load*> nil "/home/madand/.emacs.d/init.el" nil t)  ; Reading at buffer position 1076
  load-with-code-conversion("/home/madand/.emacs.d/init.el" "/home/madand/.emacs.d/init.el" t t)
  load("/home/madand/.emacs.d/init" t t)
  #[0 \205\262  \306=\203\30\310Q\202;  \311=\204\30\312Q\202;\313\307\314\315#\203*\316\202;\313\307\314\317#\203:\320\nB\321\202;\316\322\323\322\211#\210
                                                              \322=\203a\324\325\326\30\327Q!\"\323\322\211#\210
                  \322=\203`\210
                                \203\243\330
                                            !\331\232\203\243\332
                                                                 !\211\333P\334!\203}\211\202\210\334!\203\207\202\210\314\262\203\241\335
                                            \"\203\237\336\337
                                                              #\210\340\341!\210\266\f?\205\260\314\323\342\322\211#)\262\207" [init-file-user system-type delayed-warnings-list user-init-file inhibit-default-init inhibit-startup-screen ms-dos "~" "/_emacs" windows-nt "/.emacs" directory-files nil "^\\.emacs\\(\\.elc?\\)?$" "~/.emacs" "^_emacs\\(\\.elc?\\)?$" (initialization "`_emacs' init file is deprecated, please use `.emacs'") "~/_emacs" t load expand-file-name "init" file-name-as-directory "/.emacs.d" file-name-extension "elc" file-name-sans-extension ".el" file-exists-p file-newer-than-file-p message "Warning: %s is newer than %s" sit-for 1 "default"] 7 "\n\n(fn)"]()
  command-line()
  normal-top-level()

[lzhoucs]

It happens to me as well. I am on Windows 7, emacs-24.5.1, spacemacs-0.105.11

[madand]

It seems to me that the breaking change occured in the upstream smooth-scrolling. They renamed all advices to smooth-scroll, along with a massive rewrite to make it a minor global mode.

@syl20bnr please re-check on this issue after updating the smooth-scrolling package of your installation. Maybe then #5316 will not brake things for you, but rather fix :smiley: Thanks.

[syl20bnr]

I pushed a fix with a new toggle on SPC t v. Keep this issue open since it requires a hot fix.

[jrmiller82]

SPC t v doesn't work either... I get a

Error (use-package): smooth-scrolling :init: Symbol's function definition is void: smooth-scrolling-mode

[StreakyCobra]

@jrmiller82 Have you updated your packages using [Update packages] on the *spacemacs* buffer?

[jrmiller82]

@StreakyCobra I think that was the issue. Thanks for pointing it out. Updating packages right now.

[jrmiller82]

Yes. That fixed it. Don't know why I didn't do that.