search

syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.69k stars 4.89k forks source link

void variable spacemacs//unset-scroll-margin #6109

Closed sooheon closed 8 years ago

sooheon commented 8 years ago

shell layer and erc layer use this function in a hook, but this was undefined with the latest change in develop.

darkfeline commented 8 years ago

https://github.com/syl20bnr/spacemacs/pull/6113

severen commented 8 years ago

Yeah, the issue breaks mcc in python-mode.

Debugger entered--Lisp error: (void-function spacemacs//unset-scroll-margin)
  spacemacs//unset-scroll-margin()
  run-hooks(change-major-mode-after-body-hook comint-mode-hook)
  apply(run-hooks (change-major-mode-after-body-hook comint-mode-hook))
  run-mode-hooks(comint-mode-hook)
  comint-mode()
  compilation-start("python setup.py" t)
  compile("python setup.py" t)
  (if arg (call-interactively (quote compile)) (setq compile-command (format "python %s" (file-name-nondirectory buffer-file-name))) (compile compile-command t) (save-current-buffer (set-buffer (get-buffer "*compilation*")) (inferior-python-mode)))
  spacemacs/python-execute-file(nil)
  call-interactively(spacemacs/python-execute-file nil nil)
  command-execute(spacemacs/python-execute-file)

@darkfeline Thanks for the fix BTW, I manually applied it in the meanwhile and everything is going smooth.

syl20bnr commented 8 years ago

I'm on it.

syl20bnr commented 8 years ago

Merged into develop branch. I hesitated between put the function back or remove the hook, I went for the removal of the hooks, I guess a user setting the scroll margin themselves should take care of ERC and the like as well.