search

syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.67k stars 4.89k forks source link

Autoinstalling a new layer resets `powerline-default-separator` #7773

Closed mineo closed 2 years ago

mineo commented 7 years ago

Description :octocat:

Autoinstalling a new layer resets powerline-default-separator.

Reproduction guide :beetle:

Observed behaviour: :eyes: :broken_heart:

Expected behaviour: :heart: :smile:

System Info :computer:

mineo commented 7 years ago

@TheBB I'm not exactly sure what it means for an issue to be flagged "To be reproduced" for 11 days (after all, it could just mean everyone's to busy with other thing, for which I don't blame anyone :-) ), but if you're having trouble reproducing this, please let me know. I'm seeing this on my Linux machine at home and (I'm pretty sure, but would need to test again) macOS at work.

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

mineo commented 4 years ago

This still happens.

duianto commented 4 years ago

Confirmed.

PopOS 19.10 
#### System Info :computer:
- OS: gnu/linux
- Emacs: 26.3.50
- Spacemacs: 0.300.0
- Spacemacs branch: develop (rev. d17c6e1e9)
- Graphic display: t
- Distribution: spacemacs
- Editing style: vim
- Completion: helm
- Layers:
```elisp
(html auto-completion command-log emacs-lisp git helm markdown multiple-cursors
      (org :variables org-agenda-files
           '("~/org/notes.org"))
      pdf
      (shell :variables shell-default-shell 'shell shell-default-height 30 shell-default-position 'bottom)
      spell-checking syntax-checking treemacs version-control)
```
- System configuration features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY LIBSELINUX GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS
Windows 1903 
#### System Info :computer:
- OS: windows-nt
- Emacs: 26.3
- Spacemacs: 0.300.0
- Spacemacs branch: develop (rev. 710aa947b)
- Graphic display: t
- Distribution: spacemacs
- Editing style: vim
- Completion: helm
- Layers:
```elisp
(html autohotkey auto-completion c-c++ command-log emacs-lisp git github
      (gnus :variables gnus-summary-thread-gathering-function 'gnus-gather-threads-by-subject)
      go helm imenu-list javascript
      (markdown :variables markdown-live-preview-engine 'vmd markdown-command "vmd")
      multiple-cursors org pdf python racket
      (shell :variables shell-default-shell 'shell shell-default-height 30 shell-default-position 'bottom)
      spell-checking syntax-checking treemacs version-control)
```
- System configuration features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS THREADS LCMS2
duianto commented 4 years ago

The powerline-default-separator is assigned here: https://github.com/syl20bnr/spacemacs/blob/710aa947b7760dc69f864ca6cd1b2b382780005e/layers/%2Bspacemacs/spacemacs-modeline/packages.el#L105

in the function: spacemacs-modeline/init-spaceline

I don't know how/where it's loading when a layer is installed. And I don't know how to check if the user has assigned another value to the variable.

Currently if the dotspacemacs-mode-line-theme is set to spacemacs, then the separator is retrieved from the themes definition in .spacemacs. ex: dotspacemacs-mode-line-theme '(spacemacs :separator wave :separator-scale 1.5)

That might be the recommended place for defining the separators.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!