search

syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.62k stars 4.89k forks source link

Python compile mode #805

Closed cpaulik closed 9 years ago

cpaulik commented 9 years ago

Sometimes using the REPL is very inconvinient. Especially if one changes something in another module we currently have to close the REPL manually and start it again. I much prefer using comint mode for these slightly more complex cases. But doing:

This is why I wrote the code in the PR referencing this Issue. There might be a better way to do this but I'm a elisp newby so excuse any errors.

sebhahn commented 9 years ago

there is a problem using the python compile mode feature - open windows are automatically closed and compile result is not shown (tested with spacemacs v0.100.0)

syl20bnr commented 9 years ago

Oh this is a "feature" of spacemacs which closes the compilation window if there is no error. If it is annoying then it can be removed.

syl20bnr commented 9 years ago

I close the issue since it is fixed in master now but we can continue to discuss here about the other issue.

cpaulik commented 9 years ago

Hmm, I don't know if this is easily possible, but I would say that this behaviour is fine for SPC m c c but I would expect the window to stay open if the user wants to switch to the compilation window.

Another idea would to be to maybe add a dotspacemacs-compilation-window-close-delay variable which specifies how long the window should stay open. Do you think this could be useful or annoying?

sebhahn commented 9 years ago

I'm fine if it's a feature that the compile window is not shown, but by automatically closing I meant if I have two (or even more) windows open and I'm running SPC m c c one of the windows is closing unexpectedly

cpaulik commented 9 years ago

Yes closing is maybe not the best solution. If you start with a let's say 3 pane layout and compile twice only one window is left. Maybe it would be better in general to just split the window that is being compiled.

syl20bnr commented 9 years ago

I see, the compilation buffer used to be a sticky popup window but it has been removed so the auto-closing can be removed as well.

remyzorg commented 9 years ago

Hi,

Is there a way, as a spacemacs user, to keep the compilation window opened after compiling is successfull ? Even if I split my screen, the window is closed and it's verry annoying.

For example, compilation command usually includes my tests and outputs and I would like to see them.

cpaulik commented 9 years ago

@remyzorg (setq compilation-finish-function nil) should work. @syl20bnr should this be the default or do you have something else in mind?

remyzorg commented 9 years ago

@cpaulik It works, thank you.