JS auto-complete broken

ajrouvoet commented 7 years ago

Description :octocat:

Completion in react-mode is annoying (at least on develop branch): typing return (|<ret>) (where the right-paren is autoinserted) results in return (return|). Where the second return seems to be the first entry in the auto-complete menu that opened while typing the last return keyword.

Particularly it seems to occur after typing a opening paren/brace/etc.

Reproduction guide :beetle:

Tested on develop branch
Start Emacs
open a js file in react-mode. Type the above example.

System Info :computer:

OS: gnu/linux
Emacs: 25.1.1
Spacemacs: 0.200.7
Spacemacs branch: coq-layer (rev. 771faa85e)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: helm

Layers:

(windows-scripts yaml auto-completion better-defaults emacs-lisp git syntax-checking version-control markdown agda python scala javascript haskell html latex react shell coq ranger elm
             (c-c   :variables c-c  -enable-clang-support t)
             semantic gtags rust nixos)

System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11

honza commented 7 years ago

This affects me, too, and it's very annoying. I'm eager to help debug this, just not sure where to start. I had a look what changed in the auto-complete and react directories but nothing seems to indicate a possible source of this bug. I even tried disabling the fuzzy package to try and see if it affected things but no luck.

This is latest stable.

JuanCaicedo commented 7 years ago

I've been experiencing this with coffee-mode as well (also part of javascript layer). I have company-mode enabled, and tried turning it off an on again. This is also on stable. Let me know if I can provide any more details.

yetone commented 7 years ago

Same issue..

honza commented 7 years ago

I'm now using rxjs mode, as described in #8206. This brings many improvements to the React experience.

JuanCaicedo commented 7 years ago

Some combination of switching to the develop branch, reinstalling packages, switching back to master, and reinstalling again fixed this for me 😄

yetone commented 7 years ago

@honza I just try rjsx-mode. But I found it don't work well with editorconfig plugin =.=

mjkramer commented 6 years ago

For me, the js(x) problems went away when I switched to the develop branch (c1bde286) in a freshly cloned spacemacs repository (using the react, javascript, and html layers).

I'm still getting annoying pop-ups in web-mode, but that's a separate issue.

delaanthonio commented 6 years ago

This issue appears to be a duplicate of #8222. The issue is due to company-minimum-prefix-length being set to 0 in 3bbafcbfe35c8.

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

syl20bnr / spacemacs