Expand region changes behaviour of C-a on visual mode

henriquenj commented 7 years ago

Description :octocat:

After using SPC v at least once in a buffer, using C-SPC C-a to select a line to its beginning will not work. Closing the buffer and opening again will make C-SPC C-a work again as expected. Pressing C-SPC and C-a SEPARETELY (releasing control between SPC and a) will sometimes make it work again.

The bug also occurs if the user press v to enter visual mode.

Reproduction guide :beetle:

On a fresh install of spacemacs

Start Emacs
Visit any file (tested with an Elisp file)
Move the cursor to the end of a line
Use C-SPC to enter visual mode followed by C-a to select the entire line
Exit visual mode
On the same buffer, select any text using SPC v (expand region)
Exit expand region
Again try to perform selection of a line using C-SPC C-a. From now on C-a will exit visual mode, whereas prior using expand region it wouldn't.

Observed behaviour: :eyes: :broken_heart: C-a exits visual mode.

Expected behaviour: :heart: :smile: C-a should not exit visual mode, as before of using SPC v

System Info :computer:

OS: darwin
Emacs: 25.2.1
Spacemacs: 0.200.9
Spacemacs branch: master (rev. 8e1af14)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: ivy
Layers:
```
(ivy emacs-lisp)
```
System configuration features: JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES

I removed my dotspacemacs and ran git clean -fdx on .emacs.d directory to reproduce this bug.

My configuration uses C-a and C-e like vanilla Emacs, and the same behaviour happens with C-e. I usually use this sequence of keys to select a line.

$ and ^ seems to be working fine. As a workaround I could bind their commands to C-a and C-e

duianto commented 7 years ago

Confirmed

System Info :computer:

OS: windows-nt
Emacs: 25.2.2
Spacemacs: 0.200.9
Spacemacs branch: develop (rev. 7e57b1f3)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: helm

Layers:

(auto-completion autohotkey emacs-lisp git helm markdown
             (org :variables org-agenda-files
                  '("c:/Users/Username/Documents/"))
             version-control)

System configuration features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES

planigan commented 7 years ago

Confirmed on gnu/linux as well:

System Info :computer:

OS: gnu/linux
Emacs: 25.2.2
Spacemacs: 0.200.9
Spacemacs branch: develop (rev. 74ca54ad)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: helm

Layers:

(python octave helm
    (auto-completion :variables auto-completion-enable-snippets-in-popup t)
    better-defaults emacs-lisp git github org pandoc deft
    (ranger :variables ranger-show-preview t)
    (shell :variables shell-default-shell 'ansi-term shell-default-term-shell "/bin/bash" shell-default-height 30 shell-default-position 'bottom)
    spell-checking syntax-checking
    (version-control :variables version-control-diff-side 'left)
    github themes-megapack theming emoji html colors markdown aj-javascript
    (ruby :variables ruby-version-manager 'rvm)
    ruby-on-rails
    (gtags :variables gtags-enable-by-default t)
    yaml go
    (sql :variables sql-capitalize-keywords t)
    vimscript shell-scripts)

System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES

henriquenj commented 7 years ago

If more people are bothered by this behaviour, this code binds C-a and C-e to the evil versions, so it works mostly the same. You should add it to dotspacemacs/user-config

  (define-key evil-motion-state-map (kbd "C-e") 'evil-end-of-line)
  (define-key evil-motion-state-map (kbd "C-a") 'evil-first-non-blank)
  (define-key evil-insert-state-map (kbd "C-e") 'evil-end-of-visual-line)
  (define-key evil-insert-state-map (kbd "C-a") 'evil-first-non-blank)

If you want C-a to go to the first column even if it's a blank line, I think you can use evil-digit-argument-or-evil-beginning-of-line instead of evil-first-non-blank. But I haven't tested.

I found out that this setup works better when using multiple cursors, since vanilla C-a works only for one cursor (this might be a separeted bug)

henriquenj commented 7 years ago

Bug still present on develop, tested on e09385d29ef2c95cef14b992028ca85da142dad7

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

henriquenj commented 4 years ago

I don't see this behaviour anymore as of commit 27178f23e912d740ad77c0864122604a04576415. I think it can be closed.

duianto commented 4 years ago

Fell free to close any issue that you've opened, where you're unable to reproduce it on the latest develop branch.

syl20bnr / spacemacs