Report issue does not urlencode percentage signs

[jsab]

Description :octocat:

Spacemacs report issue does not url encode % signs.

This causes firefox to display "File not found" and chrome to spin a long time.

Reproduction guide :beetle:

• Start Emacs
• SPC h I
• Add a percent sign somewhere in there (not followed by two digits).
• C-c C-c
• Notice firefox or chrome won't be able to load. :eyes: :broken_heart:
• Look at the address in the address bar.
• Notice the % sign was not properly encoded.
• Encode it manually using %25
• Now firefox and chrome can load the page. :eyes: :smile:

System Info :computer:

• OS: gnu/linux
• Emacs: 25.2.1
• Spacemacs: 0.200.9
• Spacemacs branch: develop (rev. 9a9d9a0f)
• Graphic display: t
• Distribution: spacemacs
• Editing style: hybrid
• Completion: helm
• Layers:

  (better-defaults
  (spell-checking :variables spell-checking-enable-auto-dictionary t)
  syntax-checking version-control
  (auto-completion :variables auto-completion-return-key-behavior nil auto-completion-tab-key-behavior 'complete auto-completion-complete-with-key-sequence nil auto-completion-complete-with-key-sequence-delay 0.1 auto-completion-enable-snippets-in-popup t auto-completion-private-snippets-directory "~/.spacemacs.d/snippets")
  semantic
  (git :variables git-link-default-branch "master" git-commit-summary-max-length 50 git-commit-fill-column 72 magit-branch-prefer-remote-upstream t magit-display-buffer-function #'magit-display-buffer-fullframe-status-v1 magit-branch-read-upstream-first nil)
  (org :variables org-directory "~/org" org-agenda-span 14 org-agenda-dim-blocked-tasks 'invisible org-agenda-files "~/org/agendafiles" org-agenda-text-search-extra-files
    '(agenda-archives)
    org-habit-graph-column 55 org-startup-indented t org-log-into-drawer t org-log-reschedule 'note org-log-redeadline 'note org-time-clocksum-format
    '(:hours "%d" :require-hours t :minutes ":%02d" :require-minutes t)
    org-todo-keywords
    '((sequence "TODO(t)" "|" "DONE(d!)" "CANCELED(c@)"))
    org-enforce-todo-dependencies t org-outline-path-complete-in-steps nil org-refile-use-outline-path 'file org-refile-targets
    '((nil :maxlevel . 9)
      (org-agenda-files :maxlevel . 9))
    org-export-publishing-directory "~/Downloads/" org-odt-preferred-output-format "docx" org-latex-to-mathml-convert-command "latexmlmath \"%i\" --presentationmathml=%o")
  (mu4e :variables mu4e-installation-path "/usr/local/share/emacs/site-lisp/mu4e/" mu4e-msg2pdf "/opt/bin/msg2pdf" mu4e-html2text-command "w3m -dump -cols 80 -T text/html" mu4e-view-show-addresses t mu4e-headers-fields
     '((:human-date . 12)
       (:flags . 6)
       (:from . 22)
       (:subject))
     mu4e-maildir "~/Maildir" mu4e-sent-folder "/sent" mu4e-drafts-folder "/drafts" mu4e-trash-folder "/trash" mu4e-attachment-dir "~/Downloads" mu4e-get-mail-command "mbsync -Va" mu4e-update-interval 120 mu4e-hide-index-messages t mu4e-change-filenames-when-moving t mu4e-compose-dont-reply-to-self t mu4e-confirm-quit nil message-sendmail-f-is-evil 't message-sendmail-extra-arguments
     '("--read-envelope-from")
     message-insert-formatted-citation-line 'message-cite-original sendmail-program "msmtp" message-send-mail-function 'message-send-mail-with-sendmail)
  (latex :variables latex-build-command "LaTeX" latex-enable-folding t)
  restclient xkcd finance sql ess
  (clojure :variables cljr-favor-prefix-notation nil clojure--sym-forbidden-rest-chars "][\";'@\\^`~(){}\\,  \n
  /")
  (html :variables web-mode-markup-indent-offset 2)
  markdown emacs-lisp
  (c-c   :variables c-default-style "linux" c-basic-offset 3)
  common-lisp csharp javascript python yaml plantuml shell-scripts
  (shell :variables shell-default-height 30 shell-default-position 'bottom shell-default-shell 'ansi-term))

• System configuration features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 FREETYPE XFT ZLIB GTK3 X11

[jsab]

I confirm this is fixed in develop.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!