search

syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.69k stars 4.9k forks source link

Describe variable fails due to missing definition of "helm-bookmark-map" on develop #9549

Closed smile13241324 closed 7 years ago

smile13241324 commented 7 years ago

Description :octocat:

Since the latest update on develop every call of SPC h d v fails due to an undefined variable helm-bookmark-map.

Reproduction guide :beetle:

Observed behaviour: :eyes: :broken_heart: The symbol helm-bookmark-map is referenced but not defined which causes emacs to fail at displaying the variable description. A quick smart search showed me the file is referenced from the helm layer's packages.el only.

Expected behaviour: :heart: :smile: Show the description

System Info :computer:

Backtrace :paw_prints:

Debugger entered--Lisp error: (void-variable helm-bookmark-map)
  (define-key helm-bookmark-map (kbd "C-d") (quote helm-bookmark-run-delete))
  simpler-helm-bookmark-keybindings()
  run-hooks(helm-mode-hook helm-mode-on-hook)
  helm-mode(1)
  #[0 "\302\303!\210\300\211\207" [describe-variable this-command helm-mode 1] 2]()
  helm--completing-read-default("Describe variable: " [preview-copy-mml edebug-Trace-fast-mode helm-info-libffi edebug-inside-func helm-source-info-ede helm-info-gnutls sh-test debugger-previous-window semantic-decoration-mode-hook makefile-makepp-font-lock-keywords sfile-p magit-update-vc-modeline at\ point helm-info-automake tramp-compat-temporary-file-directory start-deleted electric-help-undefined edebug-form-begin-marker helm-info-viper edebug-mode-on-hook executable-magicless-file-regexp helm-info-gnutls-guile helm-info-erc edebug-print-trace-before term-dynamic-list-filename-completions edebug-eval-mode-hook helm-show-completion-display-function edebug-mark-
duianto commented 7 years ago

There's a PR: Fix helm-bookmark initialization #9547

smile13241324 commented 7 years ago

Thanks for telling me, didn't see that. Lets hope this gets merged fast.

bjarkevad commented 7 years ago

Pinning helm to melpa stable seems to work on develop:

(defun dotspacemacs/user-init ()
  (push '("melpa-stable" . "stable.melpa.org/packages/") configuration-layer--elpa-archives)
  (push '(helm . "melpa-stable") package-pinned-packages))
jajpater commented 7 years ago

Thanks for the tip bjarkevad but it doesn't work for me.

bjarkevad commented 7 years ago

@jajpater: Did you remove .emacs.d/elpa/helm-* and restart spacemacs? This should force a reinstall of helm with the pinned version.

jajpater commented 7 years ago

Thanks @bjarkevad That solved it!

bmag commented 7 years ago

Should be fixed in https://github.com/syl20bnr/spacemacs/commit/f221d7ed7308d029bb302757161ec51853c461b2, can you please verify?

duianto commented 7 years ago

@bmag Confirmed, C-h v and saving SPC f s, works again.

smile13241324 commented 7 years ago

@bmag I can also verify that your fix worked, on latest develop I can SPC h d v again.

jajpater commented 7 years ago

Yep it works. Issue can be closed.

bmag commented 7 years ago

If there are any users of master branch who suffer this error: calling SPC f b or adding (require 'helm-bookmark) to user-config should be a proper work-around.

stradicat commented 7 years ago

Workaround confirmed to work.

Stable setup: Emacs 24.5.1, Spacemacs 0.200.9 (master)

duianto commented 7 years ago

This seems to be a big enough issue, that a hotfix might be needed for the master branch. Here are some of the actions that doesn't work and only show the message:

simpler-helm-bookmark-keybindings: Symbol’s value as variable is void: helm-bookmark-map

C-h v test RET C-h f test RET

Save a new buffer: open a new empty buffer SPC b N type something: test save: SPC f s choose a location and press RET

Switch branch in a magit buffer: bb choose a branch and press RET

Some gitter comments also mentioned these:

Syncing layers SPC f e R

M-x desktop-save

Copy a file: SPC f c choose a location and press RET

Rename a file: SPC f R choose a new name and press RET

M-x magit status choose a repository, ex .emacs.d and press RET

System Info :computer:

polydevuk commented 7 years ago

Any news on this? Today I innocently ran "Update Packages" and now Spacemacs is unusable for cider-repl loading (C-c C-l) due to “Symbol’s value as variable is void: helm-bookmark-map”. I tried adding the melpa stable fix and reloading helm but I still get the same error. Latest Spacemacs 0.200.9@25.2.1

duianto commented 7 years ago

@GaryHeath Currently, the simplest solution is, as stated in the earlier comment by bmag.

Add this command: (require 'helm-bookmark) to the dotspacemacs/user-config() section in your .spacemacs file. Then restart Emacs and the helm-bookmark-map message will go away.

polydevuk commented 7 years ago

Hi Duianto

Thanks. That worked. Was fixated on the other suggestions and missed this one.

Gary

On 09/09/2017 16:26, duianto wrote:

@GaryHeath https://github.com/garyheath Currently, the simplest solution is, as stated in the earlier comment by bmag https://github.com/syl20bnr/spacemacs/issues/9549#issuecomment-327788403.

Add this command: |(require 'helm-bookmark)| to the |dotspacemacs/user-config()| section in your |.spacemacs| file. Then restart Emacs and the |helm-bookmark-map| message will go away.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/syl20bnr/spacemacs/issues/9549#issuecomment-328284014, or mute the thread https://github.com/notifications/unsubscribe-auth/ASWmPJVCQG2-2q3Sv_D2-xUT6nvl3BAXks5sgq4vgaJpZM4PO-lj.

bmag commented 7 years ago

This seems to be a big enough issue, that a hotfix might be needed for the master branch.

Yes, we are aware. syl20bnr is planning to make a hot fix release soon (I don't know exactly when, but hopefully within several days)

bmag commented 7 years ago

Reopening for visibility. The issue will be closed in the next release.

liuchong commented 7 years ago

Fixed in develop? Will it take long to merge develop into master? 😹

jakemcarthur commented 7 years ago

It seems pretty sad for this not to be in a hotfix.

stradicat commented 7 years ago

I kept getting this error on Emacs 24.5.1 (stable), using Spacemacs (stable) with the pinned, melpa-stable helm package.

Adding (require 'helm-bookmark) in .spacemacs as a workaround fixed it.

fosskers commented 7 years ago

This breaks branch switching with magit as well. The advertised work-around from above fixed it, though.

vatrat commented 7 years ago

So I also have this problem, but adding (require 'helm-bookmark) doesn't solve the problem. Running SPC f b and then closing it works. I've tried this on multiple systems running Fedora 25 and 26. I've tried adding the require line to the top and bottom of user-config, but it doesn't work. I'll try switching to using develop.

fosskers commented 7 years ago

@vatrat are you fully closing and restarting spacemacs after adding (require 'helm-bookmark)?

vatrat commented 7 years ago

Yes, I've actually had that line in my config for a few weeks. I tried to solve this issue a few weeks ago and didn't get back to it until now

mcwienczek commented 7 years ago

I am still having this problem and (require 'helm-bookmark) doesn't seem to help. Tried also to rm -rf .emacs.d/elpa/helm-* and restarting emacs.

vatrat commented 7 years ago

Switching to the development branch did fix this issue, but it seems like overkill. I do like the new features, though.

collinalexbell commented 7 years ago

@duianto Ok. Adding the (require 'helm-bookmark) worked. It confused me why deleting all of helm and then restarting emacs worked, but then if I restarted again it would fail. It was because spacemacs would download and load the "new" helm package when it was missing, but after helm was installed emacs wouldn't care to load it again on restart.

mtartare commented 7 years ago

I had the same problem when trying to switch branch with magit. Adding (require 'helm-bookmark) worked for me as well.

joneshf commented 7 years ago

Chiming in as another person on master, updated packages after a while, and hit this bug.

I'm curious what the status of fixing master is.

macalinao commented 7 years ago

Please fix this. It's breaking my workflow.

tuxayo commented 7 years ago

@macalinao The problem is known and fixed in the develop branch, no need to add messages which could be replaced by upvoting the issue or some of latest comments. (because they dilute the messages related to how to fix the issue and release the fix)

Someone correct me if I'm wrong, but the best thing to do to recover the functionality + helping to ship it would be to switch on the develop branch and report eventual bugs (or just enjoy the fix). So the next release will come sooner. Or funding the project so maintainers could spent more time on it. Or creating a bounty on this specific issue.

what-the-functor commented 7 years ago

A newbie just posted on Gitter about this bug. The fix is trivial for those whom are used to Spacemacs. However this bug has the potential to make a bad impression on new users.

It has been over a month since it was determined that there should be a hotfix. What's holding up the hot fix? Anything I can do to help?

stradicat commented 7 years ago

That's a good point. The bug can be fixed easily...if one has ever had experience with Emacs. If I had seen this error 2 months ago, as a newbie, I'd have thought "well, this doesn't work", and probably switched to Atom or Sublime.

smile13241324 commented 7 years ago

As I see that many of you are getting pretty frustrated with the state on master please consider: • We are all doing this work in our freetime • ‎We all have jobs • ‎We all have families

To be honest currently we have more issues then we have hands to fix. Therefore everybody focus on develop rather than on the old master.

Speaking of hands ... you know spacemacs is community driven, that means we expect and need our users to get involved in the project.

So if you like spacemacs please consider • If your the programming type fetch one of the random issues from the issue tracker like your generic org export issue or some layer not working properly ticket. • ‎If you are unsure pick one of the various documentation issues from #9476. This is also a pretty good way to get more familiar with your editor. • ‎If you are unsure of what is to be done for an issue you can still ask one of the team normally we are pretty fast in responding to sincere questions.

Consider the more stuff we contributors fix the more time the colaborators have for making hotfixes and working on the core. And this is what you guys are all waiting for. So please get involved.

what-the-functor commented 7 years ago

Good points @smile13241324.

We're all developers here, and I assume we all have a good understanding of what 'hotfix' means. This bug is labelled as fixed on develop. What this tells me, is that the fix is waiting on someone to merge or cherry-pick the specific parts needed for a release.

As you said this is a community driven project. The community has fixed the bug; and we are waiting on someone to do the actual release. If there is anything holding this back, please list it here so we (collectively) can contribute toward this fix.

smile13241324 commented 7 years ago

@syl20bnr Can you tell when you will be able to provide a hotfix for this on master? This issue seems to become pretty urgent, judging from the amount of people commenting here.

Is there anything blocking you where we could help?

tuxayo commented 7 years ago

Has anyone tried to backport this fix to master an check that it doesn't break anything? That's one step that the maintainer.s wouldn't have to do.

collinalexbell commented 7 years ago

I can prepare the hotfix and do a backport, since I am installing spacemacs on a new machine today. What is the fix's commit# in develop?

vbauerster commented 7 years ago

I'm a neovim user trying out spacemacs at the moment. The issue affects go layer: most of go-guru commands do not work out of the box. Also customize-variable do not popup preference window. Hope you fix this soon, because it is very discouraging for newcommers.

tuxayo commented 7 years ago

@SlightlyCyborg

What is the fix's commit# in develop?

It seems to be f221d7ed7308d029bb302757161ec51853c461b2

syl20bnr commented 7 years ago

Going to release a 200.10 with the hotfix.

antonpaisov commented 7 years ago

@syl20bnr do you mean today or in general? :)

syl20bnr commented 7 years ago

Planned tomorrow sorry, yesterday I worked on the signing of Spacelpa tarballs.

Hum ^_^

syl20bnr commented 7 years ago

Yesterday you said tomorrow so just DO IT!

Fixed in 0.200.10 🎉

fosskers commented 7 years ago

Yup, seems to fix this issue!

antonpaisov commented 7 years ago

time to close this issue :)

syl20bnr commented 7 years ago

Fixed in both branches.