syl3r86 / inventory-plus

A Foundry VTT module to enhance the dnd5e inventory. Allows to customize your Inventory in various ways.
8 stars 12 forks source link

Custom Categories Do Not Respect Ignore Item Weight checkbox #31

Open dmpunks opened 2 years ago

dmpunks commented 2 years ago

Prereq:

  1. Create a custom Category with Ignore Item Weight = T
  2. Standard Category set to Ignore Item Weight = F

Use Case 1:

  1. Move an item with weight > 0 from a standard Category (e.g. Loot) to the custom Category

Expected Result: Item weight will not be counted as encumbrance. Actual Result: Item weight is still counted in total encumbrance

Use Case 2:

  1. Set Standard Category (e.g. Loot) to Ignore Item Weight = T
  2. Set the custom Category to Ignore Item Weight = F
  3. Drag item into the Standard Category -- note that Encumbrance is correctly calculated, ignoring the item's weight
  4. Drag item back to custom Category

Expected Result: Item weight should be added back to encumbrance total Actual Result: Item weight is still ignored

apoapostolov commented 2 years ago

Confirmed, this stopped working with 0.8.9

ZeroXNoxus commented 2 years ago

In my games this still works and I'm up-to-date with both FoundryVTT (0.8.9) and DnD5e (1.4.3). Maybe some settings weren't saved for you guys? (Changed the item "Morningstar" for refference: Screenshot 2021-09-17 235728 Screenshot 2021-09-17 235735 Screenshot 2021-09-18 000510 The "Bag of Holding" category has following settings: Screenshot 2021-09-18 000016

This does also work with moving items between categories (moved the item 'Nimblewright Detector': Screenshot 2021-09-18 000143 Screenshot 2021-09-18 000202

As you can see for me the total encumberance is working fine; Can't replicate!

Are you guys using the Imperial system or the metric system for weight calculation? This could be an error related to issue #27.