search

sylab / cacheus

The design and algorithms used in Cacheus are described in this USENIX FAST'21 paper and talk video: https://www.usenix.org/conference/fast21/presentation/rodriguez
59 stars 17 forks source link

Demo doesn't work #9

Closed JerryHsh closed 2 years ago

JerryHsh commented 2 years ago

HI I am an undergraduate from Hust and I am very interested on your paper Cacheus. However, after I downloaded Fiu trace and your source code, the demo doesn't work. When you run alecar6 experiment, you will find that the request function here is wrong and an TypeError will be raised for

__place where the request is called___ for lba, write, in self.reader.read(): op, evicted = alg.request(lba, )

alecar6 request def request(self, oblock): miss = True evicted = None

The number of the parameter here simply don't match with each other here. It seems that the parameter ts here is missing.

sylab commented 2 years ago

Fixed in commit 09a2182d5263e7ae20619050f19a555e19e974ce