sylae / ligrev

XMPP MUC Utility bot
GNU General Public License v3.0
2 stars 1 forks source link

Cadence resources break everything #43

Closed sylae closed 8 years ago

sylae commented 8 years ago
$test = new \XMPPJid("sylae@calref.net/cadence/v1.10.0-calref-6-gf8ba682/1450810088764");
var_dump($test);

class XMPPJid#4 (4) {
  public $node =>
  string(5) "sylae"
  public $domain =>
  string(10) "calref.net"
  public $resource =>
  NULL
  public $bare =>
  string(16) "sylae@calref.net"
}

Caused by a bug in JAXL. 3.x JAXL trunk has it fixed. Upgrading has been a pain in the past, might as well try again.

cburschka commented 8 years ago

Is there a reason all the dots are removed?

sylae commented 8 years ago

The dots? The dots don't seem to be an issue (unless I'm missing something, are dots missing?), it's the multiple slashes that are messing it up. The submodule'd version of JAXL basically just does explode("/", $tmp[1]) to get the resource, which, yeah.

cburschka commented 8 years ago

Oh, yeah, it needs to pass a limit to explode(), which I'm guessing the new version does.

(I was confused by "calrefnet" and "v1100")

sylae commented 8 years ago

That...may be a github email thing? It renders fine on the web interface.

cburschka commented 8 years ago

Huh, the email really does strip dots from code. What a weird bug.

Edit: They stripped out ALL periods - though only from that first email. The comments are fine. It's only been happening for about 10-12 days.

Like...

Caused by a bug in JAXL 3x JAXL trunk has it fixed Upgraded has been a pain in the past, might as well try again

I thought you were just typing in a hurry. :P

sylae commented 8 years ago

quick, report a bug to github's github! :P

cburschka commented 8 years ago

And done. ;)

sylae commented 8 years ago

this is resolved with the new jaxl version