search

sylae / ligrev

XMPP MUC Utility bot
GNU General Public License v3.0
2 stars 1 forks source link

Ligrev RSS gets funky if there are multiple categories #76

Closed sylae closed 7 years ago

sylae commented 7 years ago

So RSS feeds can have multiple categories:

        <item>
        <title>To a poet.</title>
        <!-- ... -->
        <dc:creator><![CDATA[Nikki]]></dc:creator>
        <category><![CDATA[Poetry]]></category>
        <category><![CDATA[Writing]]></category>
        <category><![CDATA[darkness]]></category>
        <category><![CDATA[existence]]></category>
        <category><![CDATA[mental health]]></category>
        <category><![CDATA[poem]]></category>
        <category><![CDATA[poetry]]></category>
        <category><![CDATA[sadness]]></category>
        <category><![CDATA[words]]></category>
        <category><![CDATA[writing]]></category>
        <!-- ... -->
        </item>

Ligrev handles this weirdly

(19:53:36) Ligrev: New post in Probably, Nikki. / PoetryWritingdarknessexistencemental healthpoempoetrysadnesswordswriting: To a poet.

problem code appears to be https://github.com/sylae/ligrev/blob/master/classes/RSS.php#L75, just be as simple as a foreach loop or preferably an implode()? maybe qp has some magic for this

cburschka commented 7 years ago

Yeah, I didn't realize RSS categories were tags and non-hierarchical.

I suspect that we should either select the first (in this case "Poetry", good as any) or just omit them if there is more than one. TODO: Find out if RSS categories are ordered in any meaningful way or just occur in a random order.

On Sat, Dec 24, 2016 at 1:59 AM, Keira Sylae Aro notifications@github.com wrote:

So RSS feeds can have multiple categories:

  <item>
  <title>To a poet.</title>
  <!-- ... -->
  <dc:creator><![CDATA[Nikki]]></dc:creator>
  <category><![CDATA[Poetry]]></category>
  <category><![CDATA[Writing]]></category>
  <category><![CDATA[darkness]]></category>
  <category><![CDATA[existence]]></category>
  <category><![CDATA[mental health]]></category>
  <category><![CDATA[poem]]></category>
  <category><![CDATA[poetry]]></category>
  <category><![CDATA[sadness]]></category>
  <category><![CDATA[words]]></category>
  <category><![CDATA[writing]]></category>
  <!-- ... -->
  </item>

Ligrev handles this weirdly

(19:53:36) Ligrev: New post in Probably, Nikki. / PoetryWritingdarknessexistencemental healthpoempoetrysadnesswordswriting: To a poet.

problem code appears to be https://github.com/sylae/ ligrev/blob/master/classes/RSS.php#L75, just be as simple as a foreach loop or preferably an implode()? maybe qp has some magic for this

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sylae/ligrev/issues/76, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYYQQuPpojWCgfpErwUee5ADdLf9VA3ks5rLG6OgaJpZM4LVIMm .

cburschka commented 7 years ago

Made a patch for :first