search

sylhare / Type-on-Strap

🎨 Simplistic, responsive jekyll based open source theme
https://sylhare.github.io/Type-on-Strap/
MIT License
814 stars 902 forks source link

Refactored footer icons + many new icons #286

Closed danisztls closed 3 years ago

danisztls commented 3 years ago

rel="me" is a de facto standard for this kind of links check: https://microformats.org/wiki/rel-me

FontAwesome is missing an icon for Matrix. Request for inclusion was opened in 2018 but I guess they don't want to add an icon without Matrix.org paying the comission.

danisztls commented 3 years ago

I had refactored the footer icons, which will break configuration, but make icons easier to add and modify besides making the code cleaner with all the data on _data.

One option to improve it further is to move user data to _config,yml separating it from the icon 'templates' data.

Something like this:

_includes/social/icons.yml

github:
  pre: "https://github.com/"
  pos:
  icon:

_config.yml

me:
  github: "danisztls"
danisztls commented 3 years ago

Added a bunch of low hanging fruits.

im-coder-lg commented 3 years ago

What is Matrix mentioned in the first comment?

danisztls commented 3 years ago

What is Matrix mentioned in the first comment?

It is a decentralized real-time chat protocol. It has many clients like Element and Fluffy. Although it is no so decentralized yet as most users and servers are located on Matrix.org namespace.

im-coder-lg commented 3 years ago

So, is it a chat app server?

danisztls commented 3 years ago

So, is it a chat app server?

Protocol. Has many clients, servers/bridges.

im-coder-lg commented 3 years ago

So, why do you need to add Matrix? You could possibly add Element rather than Matrix, right?

danisztls commented 3 years ago

So, why do you need to add Matrix? You could possibly add Element rather than Matrix, right?

I can use my account with any client and connect to networks like IRC, Telegram and Discord giving that they have bridges. That is my Matrix address on matrix.org. Element is just one client.

Sylhare will be pissed of with us polluting the PR space to chat.

im-coder-lg commented 3 years ago

Well, Matrix is new here.

im-coder-lg commented 3 years ago

I got an idea. Why not you get Matrix's icon, customize it and use it here?

danisztls commented 3 years ago

I got an idea. Why not you get Matrix's icon, customize it and use it here?

Adding exceptions make the code less maintainable and it's not critical to have. I used a close substitute.

im-coder-lg commented 3 years ago

Ok

danisztls commented 3 years ago

From what I see, it will be a breaking change since you'll have to update one yaml or another

Yes

sylhare commented 3 years ago

It is now merged, I made some change to make it backward compatible 👍 Thanks for the PR @danisztls that's a whole lot of new icons we have now ehehe