search

sylhare / Type-on-Strap

🎨 Simplistic, responsive jekyll based open source theme
https://sylhare.github.io/Type-on-Strap/
MIT License
814 stars 906 forks source link

Workflow PR request(pr ready at #298) #297

Closed im-coder-lg closed 3 years ago

im-coder-lg commented 3 years ago

So, I have spent the last week learning in GitHub and got an interest in GitHub Actions. And today came a question. Can I make a PR here for adding GitHub Actions and an app(the main star here), release-drafter which helps in drafting releases when PRs are merged and shows the changes like lists. SO, I wanted to ask if I could make a PR for this. You need to do some small things if you allow me for a PR, which are:

If yes, please say yes and I will start working on the PR immediately. It will have a TON of actions, but some of them do work. I will keep the working ones only. And, if you allow me for a PR, install wip, because it doesn't need config. It won't allow the merges of PRs if the beginning of the PR is WIP: {{pr-name}} where {{pr-name}} is your PR's name. WIP will get a request and act as if it is checking, therefore blocking the PR to be merged.

im-coder-lg commented 3 years ago

And, an action I add will have a function to add labels to PRs, if the title is starting with WIP

im-coder-lg commented 3 years ago

Only for @sylhare

sylhare commented 3 years ago

Hi, can the GitHub repo for bug triage be this one? I'd rather have the questions and bugs about the theme in the same repository.

You can give it a try, I was thinking of migrating from travis to github action for the pipeline as well.

im-coder-lg commented 3 years ago

I see that you haven't made the project yet. Just open this repo, hit the Projects button and click the New project button. Then, name it as Bugs and click the drop-down. Then, hit Bug Triage and save the project. This will help later so try to allow me in that project too. It is related to an action I am going to add.

im-coder-lg commented 3 years ago

To know more about them, just go to the GitHub Learning Lab and check every course related to GitHub Actions. I strongly guess it has to be the one related to GitHub Script. Try that course and it will show that the Bug triage project you made is important.

im-coder-lg commented 3 years ago

oh yeah, you don't need to grant access to projects but you MUST create it. I will try to find an action/Probot app for marking issues with labels based on titles. And, you must have to make an instructions for issues/PRs issue, pin it and I will try to make an app which can add a reply to another issue to read that issue.

im-coder-lg commented 3 years ago

I am sure it will work btw :wink: i practised these.

im-coder-lg commented 3 years ago

I will refer the issue in the PR I make, all YOU got to do right now is install WIP, mentioned in the description to this repo only. When you have done it, just tell me here.

im-coder-lg commented 3 years ago

So, I have spent the last week learning in GitHub and got an interest in GitHub Actions. And today came a question. Can I make a PR here for adding GitHub Actions and an app(the main star here), release-drafter which helps in drafting releases when PRs are merged and shows the changes like lists. SO, I wanted to ask if I could make a PR for this. You need to do some small things if you allow me for a PR, which are:

  • [x] Install the release-drafter, stale, and request-info app from GitHub's Probot Apps after merging the PR, if allowed
  • [ ] IF you allow me, you have to make a GitHub repo project for bug triage(the pr is full-on efficiency)

If yes, please say yes and I will start working on the PR immediately. It will have a TON of actions, but some of them do work. I will keep the working ones only. And, if you allow me for a PR, install wip, because it doesn't need config. It won't allow the merges of PRs if the beginning of the PR is WIP: {{pr-name}} where {{pr-name}} is your PR's name. WIP will get a request and act as if it is checking, therefore blocking the PR to be merged.

Refer this and pr at #298

sylhare commented 3 years ago

The project is created https://github.com/sylhare/Type-on-Strap/projects/2?add_cards_query=is%3Aopen

im-coder-lg commented 3 years ago

Thanks!

im-coder-lg commented 3 years ago

So, I see you started a course, Release based workflow. You better take the course on getting started with GitHub Apps. That will help you with my PR.

sylhare commented 3 years ago

Yup I'll follow the course first then I'll see for here 👍

im-coder-lg commented 3 years ago

Check #301, it has the workflows you forgot to add. It has a LOT of workflows that you need to see by the way.

sylhare commented 3 years ago

Well that's the issue, I would rather have one PR per workflows otherwise I can't merge it, too many things at once.

im-coder-lg commented 3 years ago

Ooookaay...

im-coder-lg commented 3 years ago

Why not 2 workflows in one PR?

sylhare commented 3 years ago

One PR one feature. It's easier to see what does what.

im-coder-lg commented 3 years ago

Got them up at the repo!

im-coder-lg commented 3 years ago

check #304 , #305 , #306 , #307 , #308 for the PRs.

im-coder-lg commented 3 years ago

ping @sylhare

sylhare commented 3 years ago

I will close this issue since the PR are already there. I don't think I need it as of now since I don't have that many issues coming in. But it might get handy in the future so I'll leave them there and merge once needed :+1:

im-coder-lg commented 3 years ago

Well, merge #305 and #308, it is because 305 has a comment action, and ONLY that. 308 has the templates(bug report, feature request, comment file for 305.) Merge that because, you need that.