fix bug on pre for mail icon

SiewLinYap commented 3 years ago

Correct pre for mail should be "mailto:" without ending with "//"

mail:
  pre: "mailto:"

gitpod-io[bot] commented 3 years ago

im-coder-lg commented 3 years ago

Ah, this looks good! Glad you noticed the change, since if you click that, it would redirect you to an URL, not to your email client of choice.

im-coder-lg commented 3 years ago

Can you try clicking the Gitpod SVG and check if the build works successfully? PS: Log in with GitHub.

sylhare commented 3 years ago

Thanks for the PR, I'll take a look 😄

sylhare commented 3 years ago

Nice thanks 👍

SiewLinYap commented 3 years ago

Can you try clicking the Gitpod SVG and check if the build works successfully? PS: Log in with GitHub.

I went for a sleep after putting up the PR and a night later it was merged already. You guys are fast :D I’m not familiar with how the GitPod shall end up. I got the last part shown in the terminal as below

….
Using type-on-strap 2.3.8 from source at `.`
Bundle complete! 1 Gemfile dependency, 32 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Configuration file: /workspace/SiewLinYap.github.io/_config.yml
            Source: /workspace/SiewLinYap.github.io
       Destination: /workspace/SiewLinYap.github.io/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
       Jekyll Feed: Generating feed for posts
                    done in 0.788 seconds.
 Auto-regeneration: enabled for '/workspace/SiewLinYap.github.io'
    Server address: http://127.0.0.1:4000/Type-on-Strap/
  Server running... press ctrl-c to stop.
[2021-11-08 23:20:06] ERROR `/robots.txt' not found.

im-coder-lg commented 3 years ago

That means it worked. Gitpod is a quick IDE and I thought of using that for checks till the CIs were sanctioned. But anyway, thanks!

sylhare / Type-on-Strap

fix bug on pre for mail icon #323