sylhare / Type-on-Strap

🎨 Simplistic, responsive jekyll based open source theme
https://sylhare.github.io/Type-on-Strap/
MIT License
805 stars 899 forks source link

How to set the share by mail on the footer part of the website. #455

Closed fmorfini closed 1 month ago

fmorfini commented 1 month ago

Hi,

I'm having issues with the email/envelope icon in the footer. When I click on it, I would expect to generate a new email message either on a local email app (e.g., I'm using mail.app from a Mac) or some other way, but instead a new blank tab opens up on the web browser. I'm using the latest google chrome version 127.0.6533.100 (Official Build) (x86_64).

This is my repo and the website. Note, that I've currently removed the envelope icon to avoid issues on the live website, however the issue I was having can be reproduced by changing the following info on these fils:

/_data/icons_builder.yml (unchanged compared to the template):

mail:
  pre: "mailto:"
  icon: "fas fa-envelope"

/_data/social.yml:

share:
  email: true

/_data/icons.yml:

mail: f.morfini.work@gmail.com

Also, I tried to get around this issue by adding the email as plain text in the footer. I don't know if this is a separate issue, but the text I entered for footer_textin the _config.yml file isn't displaying in the website:

footer_text: >
  f.morfini.work@gmail.com
# Powered by <a href="https://jekyllrb.com/">Jekyll</a> with <a href="https://github.com/sylhare/Type-on-Strap">Type on Strap</a>

it does show up when I change the _includes/default/footer.liquid:

        {{ site.footer_text | default: "f.morfini@gmail.com" }}</p>

Any suggestions? Thank you for putting out this great template!

sylhare commented 1 month ago

I'll check it out, thanks for mentioning it 👍

sylhare commented 1 month ago

@fmorfini so the email share in /_data/social.yml is actually for the blog post: image

To get it as part of the footer you can edit /_data/icons.yml image

And then set the mail as:

mail: f.morfini.work@gmail.com

It's independent from the footer_text.