exiftool.py: remove +e in exiftool executable name

sylikc / pyexiftool

PyExifTool (active PyPI project) - A Python library to communicate with an instance of Phil Harvey's ExifTool command-line application. Runs one process with special -stay_open flag, and pipes data to/from. Much more efficient than running a subprocess for each command!

Other

144 stars 17 forks source link

exiftool.py: remove +e in exiftool executable name #1

Closed ickc closed 4 years ago

ickc commented 4 years ago

+'e' is introduced in commit 7b0fbfb. This "fix" might break on Windows. Tested on macOS.

It seems that the logic of commit 7b0fbfb is to dispatch on the case of Windows, default exiftool executable name as exiftool.exe, but somehow it adds e to the end later, making it calling exiftool.exee on win32 and exiftoole else (including macOS and Linux), while before commit 7b0fbfb it is calling exiftool by default in all cases.

sylikc commented 4 years ago

ickc, thanks for submitting some PR on the code. I'll merge them all. I'll be updating the code with your changes and new features.

My internal copy I've started renaming the exiftool to "pyexiftool" so it's clearer on import. I'm also planning to break it down so the file isn't so big, and be a proper package (maybe)

sylikc commented 4 years ago

looks like I fixed this as well in the code already, and i've just pushed my latest changes up. I'll look at the other PRs