Fix typo in ExifTool.terminate()

sylikc / pyexiftool

PyExifTool (active PyPI project) - A Python library to communicate with an instance of Phil Harvey's ExifTool command-line application. Runs one process with special -stay_open flag, and pipes data to/from. Much more efficient than running a subprocess for each command!

Other

144 stars 17 forks source link

Fix typo in ExifTool.terminate() #26

Closed aaronkollasch closed 2 years ago

aaronkollasch commented 3 years ago

Rename proc from the Python docs to self._process.

Also outs, errs look like they can be removed as those variables are not used, unless you'd prefer to show a warning.

sylikc commented 2 years ago

Hehe you must've seen this when it actually happened. i don't think I've ever had the TimeoutExpired happen.

I think this will be OBE when the v0.5.x branch gets merged to master. out,errs isn't used at this time, but yeah I might consider logging it or something

sylikc commented 2 years ago

fixed in the latest commit. I retained the outs,errs even though they're unused. thanks for submitting the bug report!