search

sylikc / pyexiftool

PyExifTool (active PyPI project) - A Python library to communicate with an instance of Phil Harvey's ExifTool command-line application. Runs one process with special -stay_open flag, and pipes data to/from. Much more efficient than running a subprocess for each command!
Other
148 stars 19 forks source link

Update install scripts with new module name #4

Closed csparker247 closed 4 years ago

csparker247 commented 4 years ago

Since the package name changed in de22a96, the setup script doesn't copy pyexiftool on install. This updates the script to use the new package name.

csparker247 commented 4 years ago

Just saw the conversation over on https://github.com/smarnach/pyexiftool/pull/31

Since it looks like this fork is going to get merged into mainline, I understand if this is closed without merge. Just be aware that install is currently broken.

sylikc commented 4 years ago

thanks Seth. Based on the conversation, I might undo that commit and send it back. Have you been using the tool for awhile?

csparker247 commented 4 years ago

No, I've just started using it. I'm doing some automatic image capture from machine vision cameras, and am having to add some of the basic metadata (make, model, aperture, exposure time, etc) as I acquire. I hit some issues with the upstream on Windows, so I switched to your fork to circumvent that.

szero commented 4 years ago

I'd like to mention that this and #5 makes this program installable with pip

sylikc commented 4 years ago

I'm going to roll back the pyexiftool rename, and stick with the "exiftool" name. It's been around for a long time, and ought not to rename it just for the sake of renaming

sylikc commented 4 years ago

rolled back the rename in the latest commit, so the fix is OBE