When working with the virtualenv file and docker environment I was not able to compose up. On further inspection, there were some import errors and database was not being containerized.
Fixes # (issue)
Change 'postgresql' to 'postgres' in docker-compose file.
Added some build-time configuration such as user/pw (generic), port settings and logging (for debugging)
Add build documentation for contributors
Added empty init.py file per fastAPI docs.
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
Checklist:
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
[x] Docker build and compose both seem to build/containerize the application as intended.
Please pull down this PR and test it in your local environment to verify changes. This change my effect environments differently (Operating Systems, Docker Versions, etc)
Possible Tasklist:
[ ] Differentiate between building the application for outside users and for contributors.
[ ] Determine workflow for contributors to get development going (making changes, building in docker, etc)
Description
When working with the virtualenv file and docker environment I was not able to compose up. On further inspection, there were some import errors and database was not being containerized.
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please pull down this PR and test it in your local environment to verify changes. This change my effect environments differently (Operating Systems, Docker Versions, etc)
Possible Tasklist:
Ship it
git checkout sandboxgit pull origin maingit pull origin sandbox