search

sylque / discourse-home-page

A Discourse plugin to set the home page of your Discourse instance
MIT License
1 stars 1 forks source link

Feature request: when on a localized home page, login in/out should update the home page to the right language #3

Open sylque opened 4 years ago

sylque commented 4 years ago

Suppose you're not logged-in to Discourse. Suppose your browser is in English. Suppose your Discourse interface language is set to French. When going to the forum, you are redirected to the English home page. So far so good. Now you log in to Discourse: the browser is refreshed but you stay on the English home page. Expected behavior: you are redirected to the French home page.

sylque commented 4 years ago

I doubt this feature is important:

  1. It would be useful only for the few users whose browser and Discourse languages are different.
  2. Even for those few users, it is painful only once, when they log in. If the come back later, they are already logged-in and so will get the correct home page.
  3. It would work only for the home page. For example, suppose you are not logged-in and so you land on the English home page. If you click any link to go to page X, then it's over: logging-in won't ever gets you to the French version of page X (as this plugin doesn't know about page X, only home pages).
sylque commented 4 years ago

We can imagine an option called force back to home page when logging in/out. This would solve the described issue. But the drawback would be that current page wouldn't persist when logging in. Not sure it is worth it.