Hamburger background hardcoded?

[GokulNC]

When I installed the plugin, I see that the background of my header is different from that of the hamburger's:

Upon inspecting, I see that it's coming from the discpage plugin:

Please fix this.

[sylque]

The red background of the hamburger menu means there's an issue with DiscPage. To come back to normal, you need either:

• to fix the underlying DiscPage issue, or
• to disable the plugin (using the discpage enabled setting).

The underlying issue should appear in your debug console. Can you see a DiscPage-related error rmessage there?

[GokulNC]

Yes, I see the following error:

DiscPage Error - Invalid Discourse setting "discpage page_categories": not set

For now, I have the plugin enabled, but have not added any categories for DiscPage. So, isn't this a normal scenario? Should we really treat this as an error?

[sylque]

Should we really treat this as an error?

You're right, there certainly is something to change here. I could either:

1. treat an empty "discpage page categories" setting as normal, or
2. have "discpage enable" false by default.

I lean toward 2, because I don't want users to miss the "discpage page categories" and then to wonder why it doesn't work. What do you think?

[GokulNC]

Maybe as a third option, you could:

3. Add a setting called discpage show errors. By default, it can be enabled. When there's an error, only if this boolean is enabled, you can change the hamburger color.

You can add a description for this setting indicating that if enabled, hamburger will turn red if there are errors.

[sylque]

Maybe as a third option, you could:

I don't know. Maybe this "red hamburger menu" is not a good idea and should be removed. I'll stick to option 2 for now (as it is the easiest to implement) and wait for more feedback.

[sylque]

Closing this right now. Option 2 has been implemented in v1.0.14 and more info has been added to the doc. We'll see if future users are still puzzled.