search

sylvainc / ak-oca-clabot

A minimal CLA bot for the OCA
1 stars 4 forks source link

PR OCA/l10n-canada/pull/51 is flagged by CLA bot #5

Closed gurneyalex closed 9 years ago

gurneyalex commented 9 years ago

OCA/l10n-canada/pull/51 by @veloutin is flagged by the CLA bot, despite the parent id of the partner being tagged with ECLA

gurneyalex commented 9 years ago

Tried to investigate this, and it should work. Using erppeek, I get:

community >>> client.search('res.partner', [('x_github_login', '=', 'veloutin'), '|', ('category_id', '=', 'ICLA'), ('parent_id.category_id', '=', 'ECLA')])
[1314]
gurneyalex commented 9 years ago

in #6 I added a test using the json data sent by the github API from this PR, and it does not trigger the generation of the flagging message. I'm a bit lost as to what is happening here.

I've updated the code to add some logging statements in hope it will help me understand what is going on.

gurneyalex commented 9 years ago

I tried redelivering the payload from the github administration screen and the PR is now flagged as OK. I'm closing here as cannot reproduce.

@veloutin if you have the same issue on new PRs please reopen this issue (with a pointer to the incorrect PR). I hope the instrumentation I added in the bot will be enough to help finding out what's wrong.