search

sylvainjule / kirby-colorextractor

Extract dominant / average color from any image. Kirby 3 and 4.
39 stars 7 forks source link

Image must be a gd resource #13

Closed eriksachse closed 1 year ago

eriksachse commented 3 years ago

Uploaded images (jpg) are giving me the following error: Image must be a gd resource

To reproduce: Make photo with iPhone, upload in panel. PNG's not working as well.

Kirby 3.0

mingyeungs commented 3 years ago

This happens on PHP 8 due to this dependency [League\ColorExtractor], and the issue has been reported there as well. However it seems that the project is no longer being maintained...

sylvainjule commented 2 years ago

Unfortunately, even though the PR fixing this has been noticed, the main contributor to this package from @thephpleague hasn't able to merge it yet: https://github.com/thephpleague/color-extractor/pull/68#issuecomment-913042220

The alternative package that I know of is color-thief, which currently has the same issue: https://github.com/ksubileau/color-thief-php/issues/50

So, I guess it's a waiting game…

mattwolff commented 2 years ago

It looks like the latest release of color-thief-php (v2, March 2022) now supports PHP 8.

arnoson commented 1 year ago

It seems that the issue in thephpleague/color-extractor has been resolved in version 0.4.0. But I guess we have to wait until simple image updates color-extractor and then Kirby updates simple image?

bnomei commented 1 year ago

i created a PR at that lib today. lets see how that goes.

nncrns commented 1 year ago

Any news? The issues at simple image has been closed, meaning that this plugin could now be updated?

johannesverwoerd commented 1 year ago

I am also curious to know if this great plugin will be updated. Thanks!