Issue#66 properly stop threads and sockets

sylvainlaurent / JDBC-Performance-Logger

A JDBC driver wrapper and GUI to analyze statement performance

Apache License 2.0

84 stars 26 forks source link

Issue#66 properly stop threads and sockets #68

Closed madness-inc closed 6 years ago

madness-inc commented 6 years ago

Hi Sylvain,

this PR explicitly calls PerfLoggerRemoting.start() and PerfLoggerRemoting.stop() in WrappingDriver.load() and WrappingDriver.unload().

This ensures that all sockets being closed.

Regards Matthias

madness-inc commented 6 years ago

Hm,

the test that I've added failed on CI, although working for me. Will check this...

Regards Matthias

madness-inc commented 6 years ago

Works now.

madness-inc commented 6 years ago

Hi, thank you very much for your feedback. I've applied the requested changes, CI build is passing.

Regards Matthias

madness-inc commented 6 years ago

Hi Sylvain,

thank you for your support! We'll use that new feature in our application platform appNG, where the the webapplication can be auto-updated and thus needs to be restarted. With the PR applied, these restarts now won't fail anymore because of blocked ports :-)

Regards Matthias