search

sylvainlaurent / JDBC-Performance-Logger

A JDBC driver wrapper and GUI to analyze statement performance
Apache License 2.0
84 stars 26 forks source link

Add support for HikariCP #70

Closed lukashinsch closed 4 years ago

lukashinsch commented 5 years ago

This PR adds support for HikariCP which is the default in spring boot 2.x.

lukashinsch commented 5 years ago

Not sure about the tests, couldn't get them to succeed locally even without the changes...

lukashinsch commented 5 years ago

Hi @sylvainlaurent, any interest in this? Or is this (great and useful) tool no longer maintained?

sylvainlaurent commented 5 years ago

hello,

thanks @lukashinsch for your contribution. I still maintain this project but not very actively as I no longer use it very often... Your PR seems to be fine, I would just like it to contain some tests.. you say that the tests do not work on master branch currently? what's the problem?

lukashinsch commented 5 years ago

yeah, I couldn't get the tests to run locally from master, don't remember what the issue was need to take another look when I got a minute

sylvainlaurent commented 4 years ago

I removed specific-support for spring-boot as SB2 does not allow to apply a Bean post processor on the datasource. The logger still works, but you have to prepend the JDBC url with jdbcperflogger: and possibly set the driver class name to ch.sla.jdbcperflogger.driver.WrappingDriver