Providers - Githubissues

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan (13 warnings, 2 commits squashed)

> `netlify/lambdas/domains.js` 57% changes removed in move to typescript, ... > `...ify/lambdas/providers/index.js` 88% changes removed in move to typescript, ... > `netlify/lambdas/auth.js` 94% changes removed in test: netlify lambda... > `...mbdas/providers/gandi/index.js` 89% changes removed in test: netlify lambda... > `.../auth/login/login.component.ts` 62% changes removed in update deps

list domains OK

> `...mbdas/providers/gandi/index.js` 54% changes removed in move to typescript, ... > `netlify/lambdas/domains.js` 50% changes removed in test: netlify lambda... > `netlify/lambdas/functions.js` 86% changes removed in move to typescript, ...

get mailboxes OK

> `netlify/lambdas/mailboxes.js` 45% changes removed in move to typescript, ...

get mailbox details OK

> `netlify/lambdas/mailbox.js` 45% changes removed in move to typescript, ...

update aliases OK

update deps ... upgrade to angular 9

> Squashed 2 commits: > - update deps > - upgrade to angular 9 > `package.json` 60% changes removed in update deps, fix son...

update angular material to 9

> `package-lock.json` 86% changes removed in test: netlify lambda...

update to angular 9 OK

update

> `package.json` 83% changes removed in test: netlify lambda...

typo

test: netlify lambda typescript

> `netlify/lambdas/aliases.js` 61% changes removed in move to typescript, ... > `netlify/lambdas/domains.js` 67% changes removed in move to typescript, ... > `netlify/lambdas/functions.js` 92% changes removed in move to typescript, ... > `netlify/lambdas/mailbox.js` 62% changes removed in move to typescript, ... > `netlify/lambdas/auth.js` 88% changes removed in move to typescript, ... > `netlify/src/hello.ts` 64% changes removed in move to typescript, ... > `netlify/lambdas/mailboxes.js` 62% changes removed in move to typescript, ... > `...ify/lambdas/providers/index.js` 93% changes removed in move to typescript, ...

typescript + angular + netlify dev OK

move to typescript, support multiple providers

> `netlify/src/aliases.ts` 56% changes removed in test > `netlify/src/mailboxes.ts` 80% changes removed in test > `netlify/src/domains.ts` 76% changes removed in test > `netlify/src/auth.ts` 70% changes removed in test > `netlify/src/mailbox.ts` 66% changes removed in test

fix: typo

> `...etlify/spec/auth/gandi.spec.js` 50% changes removed in add mock + tests

add mock + tests

> `.env.dist` 50% changes removed in typo > `...y/src/providers/gandi/index.ts` 75% changes removed in test

sonar update sonar update sonar update update deps, fix sonar issues sonar update remove circle ci remove circle ci add missing deps

test debug

> `netlify/src/providers/index.ts` 50% changes removed in fix: debug mode bad ...

typo

fix: debug mode bad check

> `netlify/src/aliases.ts` 92% changes removed in test

add sentry test test test