sylvanaar / prat-3-0

Prat-3.0 is a chat enhancement addon for world of warcraft
https://www.curseforge.com/wow/addons/prat-3-0
GNU General Public License v3.0
25 stars 45 forks source link

9.0 pre-patch - attempt to call global 'GuildRoster' (a nil value) #140

Closed zmoose closed 3 years ago

zmoose commented 4 years ago

Seeing the following error with the 9.0 pre-patch

7x Prat-3.0-3.8.26\modules\PlayerNames.lua:1357: attempt to call global 'GuildRoster' (a nil value) [string "@Prat-3.0-3.8.26\modules\PlayerNames.lua"]:1357: in function `?' [string "@LibSharedMedia-3.0-8020003\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:119: in function <...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>

[string "@LibSharedMedia-3.0-8020003\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...edia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@LibSharedMedia-3.0-8020003\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire' [string "@TomTom\libs\AceEvent-3.0\AceEvent-3.0-4.lua"]:120: in function <...aceTomTom\libs\AceEvent-3.0\AceEvent-3.0.lua:119>

domi1294 commented 4 years ago

I believe this is happening because at some point during BfA Blizzard moved many if not all of the guild functions to the C_GuildInfo namespace and now they deleted the deprecated functions that were still being used

ghost commented 4 years ago

Replacing the offending line with C_GuildInfo.GuildRoster() seems to suppress the error as a workaround. I assume this also preserves the functionality, but I didn't verify that.

Vashidu commented 4 years ago

135 should fix some of the issues, seems others need to be updated still.

voidzone commented 4 years ago

Prat-3.0\modules\PlayerNames.lua

Line 1155:       GuildRoster()
Line 1323:     if IsInGuild() then GuildRoster() end
Line 1357:       GuildRoster()
Krattan commented 4 years ago

Classic is till using the old command so if you are going to fix it for both you need: if Prat.IsClassic then GuildRoster() else C_GuildInfo.GuildRoster() end

github-actions[bot] commented 3 years ago

This issue was flagged as stale