search

sylvanaar / prat-3-0

Prat-3.0 is a chat enhancement addon for world of warcraft
https://www.curseforge.com/wow/addons/prat-3-0
GNU General Public License v3.0
25 stars 45 forks source link

[Classic] v3.9.0 PlayerName and Invites module errors #160

Closed Road-block closed 3 years ago

Road-block commented 3 years ago

Describe the bug Addon Spams errors on load

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

1x Prat-3.0-3.9.0\modules\PlayerNames.lua:1152: attempt to call field 'GuildRoster' (a nil value)
Prat-3.0-3.9.0\modules\PlayerNames.lua:1152: in function 'OnModuleEnable'
Prat-3.0-3.9.0\addon\modules.lua:189: in function <Prat-3.0\addon\modules.lua:178>
25x Prat-3.0-3.9.0\modules\PlayerNames.lua:1354: attempt to call field 'GuildRoster' (a nil value)
Prat-3.0-3.9.0\modules\PlayerNames.lua:1354: in function '?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:119: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[C]:: ?
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function 'Fire'
Ace3\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>

3x Prat-3.0-3.9.0\modules\Invites.lua:393: attempt to call field 'CanInvite' (a nil value)
Prat-3.0-3.9.0\modules\Invites.lua:393: in function <Prat-3.0\modules\Invites.lua:386>
(tail call): ?
(tail call): ?
[C]:: in function 'gsub'
Prat-3.0-3.9.0\services\patterns.lua:197: in function 'MatchPatterns'
Prat-3.0-3.9.0\addon\addon.lua:695: in function <Prat-3.0\addon\addon.lua:613>
(tail call): ?
FrameXML\ChatFrame.lua:2797: in function 'ChatFrame_OnEvent'
[string "*:OnEvent"]:1: in function <[string "*:OnEvent"]:1>

Version Information (please complete the following information):

Road-block commented 3 years ago

GuildRoster is not namespaced under C_GuildInfo in current live Classic (maybe you tested on 1.13.6 PTR and they're transitioning to some 9.x stuff there?)

CanInvite similarly is not namespaced under C_PartyInfo, the previous CanGroupInvite needs to be used for live Classic.

I do not have all Prat modules enabled so it's likely there's more premature changes like those that I didn't catch.

Foamzr commented 3 years ago

Can confirm that I am getting the same as above. Whenever I have a message that says 'inv' or 'invite' I get a LUA error, and it also does not show in my chat frame.

LUA_Error_Prat.txt

Prat 3.0-3.9.0

samzorio commented 3 years ago

Same thing here had to revert to previous version

KyrosKrane commented 3 years ago

This is fixed by #167

github-actions[bot] commented 3 years ago

This issue was flagged as stale