search

sylvanaar / prat-3-0

Prat-3.0 is a chat enhancement addon for world of warcraft
https://www.curseforge.com/wow/addons/prat-3-0
GNU General Public License v3.0
25 stars 45 forks source link

Fixes to invite.lua module (works with both classic and retail) #162

Closed KyrosKrane closed 3 years ago

KyrosKrane commented 3 years ago

Fix #161

tbpoetke commented 3 years ago

Hmm, I merged your fix for myself, but still have error messages sometimes :(

KyrosKrane commented 3 years ago

My fix was not a complete fix for all the bugs in that file; it was specifically for this one issue. Later today, I'll try to take a look at the other issues in that file and see if I can fix some of them.

On Tue, Oct 20, 2020 at 12:17 PM Aschenbecher notifications@github.com wrote:

Hmm, I merged your fix for myself, but still have error messages sometimes :(

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sylvanaar/prat-3-0/pull/162#issuecomment-713014444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADP7Z44NWUFVZ6VAFXRWNLSLXA2JANCNFSM4SXEI6DA .

tbpoetke commented 3 years ago

yes, sry, I just saw that, this fix is just for the invite bug, not for the playername module, sorry!

KyrosKrane commented 3 years ago

I made some changes to allow the same codebase to work on both retail and classic.

KyrosKrane commented 3 years ago

@Aschenbecher See if #167 fixes your GuildRoster issue, please - you can comment there with feedback.