sylvanaar / prat-3-0

Prat-3.0 is a chat enhancement addon for world of warcraft
https://www.curseforge.com/wow/addons/prat-3-0
GNU General Public License v3.0
25 stars 45 forks source link

Raid icons in text not working with different language clients #212

Open Moryggy opened 3 years ago

Moryggy commented 3 years ago

First of all, not sure if this is a bug, a missing feature or something else. I love your addon and your work and I've found out this works with other addons like ElvUI, so I'm surprised it does not work with Prat.

I want to thank you for creating and mantaining this addong and for taking a look at this.

Describe the bug Raid icons in chat do not work when written in different languages. I know this is standard chat behaviour but it works in other addons like ElvUI. Also can't filter them to make it work.

To Reproduce (I'm alwas putting text in between " ") You need one WoW writer in English and reader in any other language I'm using the example with Star icon but it is the same for circle/coin, square/blue, skull, etc.

If you write "{star}" in a English client it will show in chat the raid icon star. In another language (I'm using Spanish) it just shows the text "{star}" instead of the icon. Other addons like ElvUI show the icon properly. A workaround is writing "{rt1}" but that would mean chaning everyone's way of doing things, which won't work.

My workaround with prat was to try to filter "{star}" and get it converted to "{rt1}". It does work but at text level, so Prat does not recognize the icon and just translates the pure text and shows me "{rt1}". If I send "{rt1}" directly it will actually show the star icon as expected.

Expected behavior When sending any text such us "{star}", "{Star}". "{circle}", etc. to get the raid icon

Screenshots Prat raid icons language issues.docx

Version Information (please complete the following information):

Addons you are running No other chat addon in use. Addons in use: Shadow unit frames, bartender, omnicc, tsm, bagnon, dbm, gtfo, Tested also with only Prat enabled and result has been the same