search

sylvanaar / prat-3-0

Prat-3.0 is a chat enhancement addon for world of warcraft
https://www.curseforge.com/wow/addons/prat-3-0
GNU General Public License v3.0
25 stars 45 forks source link

Update to Burning Crusade Classic #219

Open Hypertonic18 opened 3 years ago

Hypertonic18 commented 3 years ago

Describe the bug A clear and concise description of what the bug is. The latest Classic version of Prat no longer works in Burning Crusade Classic

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Version Information (please complete the following information):

Addons you are running If possible list which addons you were using when the bug occurred.

MeikTranel commented 3 years ago

I've tried contacting @sylvanaar in discord to no luck - while we're waiting I've compiled all recent fixes from community members regarding lua errors and missing backdrop here: https://github.com/MeikTranel/prat-3-0

You can find archives for all game versions in the github actions: https://github.com/MeikTranel/prat-3-0/actions/workflows/ci.yml Latest Build Artifact: https://github.com/MeikTranel/prat-3-0/suites/2810300209/artifacts/62518047

One thing still outstanding is the PVP join prompt dialog bugging - its hard to track tho since its only reproduceable when a queue pops.

Nimbix-wow commented 3 years ago

I've tried contacting @sylvanaar in discord to no luck - while we're waiting I've compiled all recent fixes from community members regarding lua errors and missing backdrop here: https://github.com/MeikTranel/prat-3-0

You can find archives for all game versions in the github actions: https://github.com/MeikTranel/prat-3-0/actions/workflows/ci.yml Latest Build Artifact: https://github.com/MeikTranel/prat-3-0/suites/2810300209/artifacts/62518047

One thing still outstanding is the PVP join prompt dialog bugging - its hard to track tho since its only reproduceable when a queue pops.

Still showing as "Out of date" in the BCC Addon List

image

MeikTranel commented 3 years ago

@Nimbix-wow Updated the libraries toc - forgot about that one - use this artifact https://github.com/MeikTranel/prat-3-0/suites/2826912505/artifacts/62987569

Hypertonic18 commented 3 years ago

Thanks @MeikTranel. When a BG queue pops and I click Enter Battle, I get an error message that says "Prat-3.0 has been blocked from an action only available to the Blizzard UI. You can disable this addon and reload the UI."

The only way for me to enter the BG is to right click on the BG icon.

Devinmarra commented 3 years ago

I've tried contacting @sylvanaar in discord to no luck - while we're waiting I've compiled all recent fixes from community members regarding lua errors and missing backdrop here: https://github.com/MeikTranel/prat-3-0

You can find archives for all game versions in the github actions: https://github.com/MeikTranel/prat-3-0/actions/workflows/ci.yml Latest Build Artifact: https://github.com/MeikTranel/prat-3-0/suites/2810300209/artifacts/62518047

One thing still outstanding is the PVP join prompt dialog bugging - its hard to track tho since its only reproduceable when a queue pops.

Hi, this is the absolute worst news I could give, but Sylvanaar passed away 2 months ago. Suddenly, tragically. I worked with him for 4-5 years, he was my mentor and my friend....I want to make sure his contributions to the community can live on.

Please help me share this with anyone that may be interested in maintaining his addons. I'm not sure if you have a community discord, but I'd appreciate a link to join so I can make sure everyone knows. I want to find a maintainer for his wow stuff.

Hypertonic18 commented 3 years ago

Wow, I'm terribly sorry to hear that. I didn't know anything about Sylvanaar, but Prat has always been one of my favorite addons and I'm appreciative of his work. I'm not aware of a community discord, but I'm sure there are plenty of people that would be interested in maintaining his wow addons. This github page is probably a good place to start.

MeikTranel commented 3 years ago

@Devinmarra i sent you an email.

Devinmarra commented 3 years ago

Thank you both. I've raised a couple issues similar to what I posted here on some of his other github repos. He was brilliant on a completely different level, I couldn't begin to take over myself but I hope I can at least find the right people to ensure his WoW legacy lives on.

Nimbix-wow commented 3 years ago

@Devinmarra

This is very sad to hear. My condolences.

Prat and WIM has been on my "Must have" list of addons for WoW for as long as I can remember playing this game. I truly appreciated his work. His addons were downloaded 50 million times from curseforge.com alone. Rest assured, his World of Warcraft legacy will live on.

Best regards Nimbix

meflakcannon commented 3 years ago

I captured the error.

2x [ADDON_ACTION_FORBIDDEN] AddOn 'Prat-3.0-3.9.1-1-g6978fc8' tried to call the protected function 'AcceptBattlefieldPort()'. [string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519> [string "=[C]"]: in function AcceptBattlefieldPort' [string "@FrameXML\StaticPopup.lua"]:768: in functionOnAccept' [string "@FrameXML\StaticPopup.lua"]:5048: in function `StaticPopup_OnClick'

Looking into it. I'll commit code to the Miek Github after a deeper analysis

Devinmarra commented 3 years ago

Great work, thanks a lot for taking this on and sharing. Just so you all know, I've contacted Jon's family to let them know about his projects on GitHub. If he did not name a successor to his repos, I volunteered to help carry on his legacy myself. If they decide to go that route, I intend to find the right people to maintain his projects. His family's wishes are paramount, so I appreciate your patience, and I'm sure they do too. I'm told they are deeply grateful for the outpouring of support from the community, it's really quite beautiful.

meflakcannon commented 3 years ago

After reviewing several other addons and some forum posts this isn't exclusive to Prat3. TukUI is saying the taint issue is on Blizzard. Disabling ALL addons will cause the Enter battle button to still break. I'm experimenting with an addon called safe queue to see if it's "workaround" is actually a plausible way to get into battlegrounds, but Prat itself never explicitly invokes the AcceptBattlefieldPorT() command.