search

sylvanaar / prat-3-0

Prat-3.0 is a chat enhancement addon for world of warcraft
https://www.curseforge.com/wow/addons/prat-3-0
GNU General Public License v3.0
25 stars 45 forks source link

Messages in saved history are not fading correctly #98

Closed KyrosKrane closed 4 years ago

KyrosKrane commented 4 years ago

Fading of old messages with chat history turned on is inconsistent. This is with Prat v 3.8.20.

I logged in and AFK'ed. When I noticed a new message, I looked at my chat window and saw this: image

After a while, it fades to this: image

By scrolling down to refresh the chat, it looks like this. image

Essentially it seems that messages saved in history are not being faded out any more at the timeout.

Possibly related issue, the time since last login appears to have changed too - it's showing negative seconds, among other oddities.

sylvanaar commented 4 years ago

Yes - that negative time would be related in a big way. If the time for those lines is in the future - they will never fade.

Now I wonder how they got that way. Can you grab some examples of entire message structure for a few of the chat lines from your saved variables

KyrosKrane commented 4 years ago

I found the SavedVariables for that character, and edited the file to only keep the sections for ChatFrame3 (the one displayed in those screeshots) for privacy. I didn't remove anything within the ChatFrame3 sections. I've attached the file. If you need my full saved variables file, I can provide that to you directly - either email to you, or you can provide me your GPG public key and I can encrypt and upload it here.

CF3.txt

KyrosKrane commented 4 years ago

I'm seeing this on other characters with more active chats as well; the same fading issue is happening for them. If you need those, I can provide the full saved variables again directly or encrypted here.

sylvanaar commented 4 years ago

Oh right I see. This was a huge oversight when I moved to use the blizzard internal chatframe buffer instead of keeping my own.

KyrosKrane commented 4 years ago

Retested on v3.8.21. Seems fixed, and working the way it used to before. Thanks!

sylvanaar commented 4 years ago

Retested on v3.8.21. Seems fixed, and working the way it used to before. Thanks!

Great!